Skip to content

Fix linker tests not running and show full path during trimming test execution #69118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 5 commits into from
May 12, 2022
Merged

Fix linker tests not running and show full path during trimming test execution #69118

ViktorHofer merged 5 commits into from
May 12, 2022

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 10, 2022 •
edited
Loading

Fixes #38377
Fixes #69139

Also addresses @danmoseley's additional feedback regarding separating the "..." from the path.

@ViktorHofer
Show full path during trimming test execution
070e336 
Fixes #38377. Also addresses @danmoseley's additional feedback regarding separating the "..." from the path.
@ViktorHofer ViktorHofer requested review from joperezr and layomia May 10, 2022 10:19
@ViktorHofer ViktorHofer self-assigned this May 10, 2022
@ghost
Copy link

ghost commented May 10, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #38377. Also addresses @danmoseley's additional feedback regarding separating the "..." from the path.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries
Milestone: -

@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 10, 2022

The NativeAOT System.Reflection.Tests work item timed out and the arm64 leg timed out as well (presumably because of the limited hardware pool).

@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 10, 2022 •
edited
Loading

I don't think trimming tests are running at all (unrelated to this PR). I.e. https://dnceng.visualstudio.com/public/_build/results?buildId=1762286&view=logs&j=eb951b81-6f9f-5627-0593-6e7e925eb8a5&t=55619121-b736-513e-b9cc-23d0fc111be3 doesn't show any test execution after the test libraries are restored.

Looking into this more closely now.

@ViktorHofer ViktorHofer mentioned this pull request May 10, 2022
Closed
@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 10, 2022

Opened #69139.

@ViktorHofer ViktorHofer changed the title Show full path during trimming test execution Fix linker tests not running and show full path during trimming test execution May 10, 2022
joperezr
joperezr reviewed May 10, 2022
View reviewed changes
@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 11, 2022

@eerhardt @joperezr @tarekgh does the linker test change look good to you? I would like to get this in asap to re-enable linker testing in CI.

@ericstj ericstj requested a review from tarekgh May 11, 2022 17:53
tarekgh
tarekgh approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 2 minor comments, LGTM otherwise.

eerhardt
eerhardt approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and fix here, @ViktorHofer. LGTM

@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 12, 2022

Failure is #69231

@ViktorHofer ViktorHofer merged commit 35e4779 into main May 12, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch May 12, 2022 05:52
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezr joperezr joperezr left review comments

@danmoseley danmoseley danmoseley approved these changes

@eerhardt eerhardt eerhardt approved these changes

@tarekgh tarekgh tarekgh approved these changes

@layomia layomia Awaiting requested review from layomia

Assignees

@ViktorHofer ViktorHofer

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Libraries linker tests aren't running in CI Show full path for manually added test files in linker trimming tests output

6 participants

@ViktorHofer @danmoseley @eerhardt @tarekgh @joperezr