Ensure that floating-point conversions exist for Int128 and UInt128

dotnet · tannergooding · May 19, 2022 · Apr 11, 2022 · May 2, 2022 · May 3, 2022
commit 9de4e76795a06e49e42844318a02c02657a57170
diff --git a/THIRD-PARTY-NOTICES.TXT b/THIRD-PARTY-NOTICES.TXT
@@ -1072,4 +1072,30 @@ Copyright (c) Microsoft Corporation.
 Licensed under the MIT License.
 
 Available at
-https://github.com/microsoft/msquic/blob/main/LICENSE
+https://github.com/microsoft/msquic/blob/main/LICENSE
+
+License notice for m-ou-se/floatconv
+-------------------------------
+
+Copyright (c) 2020 Mara Bos <[email protected]>
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this
+   list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright notice,
+   this list of conditions and the following disclaimer in the documentation
+   and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Decimal.DecCalc.cs b/src/libraries/System.Private.CoreLib/src/System/Decimal.DecCalc.cs
@@ -17,7 +17,7 @@ public partial struct Decimal
         internal uint Low => (uint)_lo64;
         internal uint Mid => (uint)(_lo64 >> 32);
 
-        private ulong Low64 => _lo64;
+        internal ulong Low64 => _lo64;
 
         private static ref DecCalc AsMutable(ref decimal d) => ref Unsafe.As<decimal, DecCalc>(ref d);
 

diff --git a/src/libraries/System.Private.CoreLib/src/System/Decimal.cs b/src/libraries/System.Private.CoreLib/src/System/Decimal.cs
@@ -1296,6 +1296,10 @@ public static decimal CreateChecked<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (decimal)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1320,6 +1324,10 @@ public static decimal CreateChecked<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (decimal)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1364,6 +1372,12 @@ public static decimal CreateSaturating<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                var actualValue = (Int128)(object)value;
+                return (actualValue > new Int128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF)) ? MaxValue :
+                       (actualValue < new Int128(0xFFFF_FFFF_0000_0000, 0x0000_0000_0000_0001)) ? MinValue : (decimal)actualValue;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1388,6 +1402,11 @@ public static decimal CreateSaturating<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                var actualValue = (UInt128)(object)value;
+                return (actualValue > new UInt128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF)) ? MaxValue : (decimal)actualValue;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1432,6 +1451,21 @@ public static decimal CreateTruncating<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                var actualValue = (Int128)(object)value;
+
+                if (Int128.IsNegative(actualValue))
+                {
+                    actualValue = (-actualValue) & new Int128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF);
+                    return -(decimal)actualValue;
+                }
+                else
+                {
+                    actualValue &= new Int128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF);
+                    return (decimal)actualValue;
+                }
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1456,6 +1490,12 @@ public static decimal CreateTruncating<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                var actualValue = (UInt128)(object)value;
+                actualValue &= new UInt128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF);
+                return (decimal)actualValue;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1531,6 +1571,19 @@ public static bool TryCreate<TOther>(TOther value, out decimal result)
                 result = (long)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                var actualValue = (Int128)(object)value;
+
+                if ((actualValue > new Int128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF)) || (actualValue < new Int128(0xFFFF_FFFF_0000_0000, 0x0000_0000_0000_0001)))
+                {
+                    result = default;
+                    return false;
+                }
+
+                result = (decimal)actualValue;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 result = (nint)(object)value;
@@ -1561,6 +1614,19 @@ public static bool TryCreate<TOther>(TOther value, out decimal result)
                 result = (ulong)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                var actualValue = (UInt128)(object)value;
+
+                if (actualValue > new UInt128(0x0000_0000_FFFF_FFFF, 0xFFFF_FFFF_FFFF_FFFF))
+                {
+                    result = default;
+                    return false;
+                }
+
+                result = (decimal)actualValue;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 result = (nuint)(object)value;

diff --git a/src/libraries/System.Private.CoreLib/src/System/Double.cs b/src/libraries/System.Private.CoreLib/src/System/Double.cs
@@ -1016,6 +1016,10 @@ public static double CreateChecked<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (double)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1040,6 +1044,10 @@ public static double CreateChecked<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (double)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1084,6 +1092,10 @@ public static double CreateSaturating<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (double)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1108,6 +1120,10 @@ public static double CreateSaturating<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (double)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1152,6 +1168,10 @@ public static double CreateTruncating<TOther>(TOther value)
             {
                 return (long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (double)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (nint)(object)value;
@@ -1176,6 +1196,10 @@ public static double CreateTruncating<TOther>(TOther value)
             {
                 return (ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (double)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (nuint)(object)value;
@@ -1242,6 +1266,11 @@ public static bool TryCreate<TOther>(TOther value, out double result)
                 result = (long)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                result = (double)(Int128)(object)value;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 result = (nint)(object)value;
@@ -1272,6 +1301,11 @@ public static bool TryCreate<TOther>(TOther value, out double result)
                 result = (ulong)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                result = (double)(UInt128)(object)value;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 result = (nuint)(object)value;

diff --git a/src/libraries/System.Private.CoreLib/src/System/Half.cs b/src/libraries/System.Private.CoreLib/src/System/Half.cs
@@ -1214,6 +1214,10 @@ public static Half CreateChecked<TOther>(TOther value)
             {
                 return (Half)(long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (Half)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (Half)(long)(nint)(object)value;
@@ -1238,6 +1242,10 @@ public static Half CreateChecked<TOther>(TOther value)
             {
                 return (Half)(ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (Half)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (Half)(ulong)(nuint)(object)value;
@@ -1282,6 +1290,10 @@ public static Half CreateSaturating<TOther>(TOther value)
             {
                 return (Half)(long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (Half)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (Half)(long)(nint)(object)value;
@@ -1306,6 +1318,10 @@ public static Half CreateSaturating<TOther>(TOther value)
             {
                 return (Half)(ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (Half)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (Half)(ulong)(nuint)(object)value;
@@ -1350,6 +1366,10 @@ public static Half CreateTruncating<TOther>(TOther value)
             {
                 return (Half)(long)(object)value;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                return (Half)(Int128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 return (Half)(long)(nint)(object)value;
@@ -1374,6 +1394,10 @@ public static Half CreateTruncating<TOther>(TOther value)
             {
                 return (Half)(ulong)(object)value;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                return (Half)(UInt128)(object)value;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 return (Half)(ulong)(nuint)(object)value;
@@ -1440,6 +1464,11 @@ public static bool TryCreate<TOther>(TOther value, out Half result)
                 result = (Half)(long)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(Int128))
+            {
+                result = (Half)(Int128)(object)value;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nint))
             {
                 result = (Half)(long)(nint)(object)value;
@@ -1470,6 +1499,11 @@ public static bool TryCreate<TOther>(TOther value, out Half result)
                 result = (Half)(ulong)(object)value;
                 return true;
             }
+            else if (typeof(TOther) == typeof(UInt128))
+            {
+                result = (Half)(UInt128)(object)value;
+                return true;
+            }
             else if (typeof(TOther) == typeof(nuint))
             {
                 result = (Half)(ulong)(nuint)(object)value;
@@ -1488,10 +1522,10 @@ public static bool TryCreate<TOther>(TOther value, out Half result)
         //
 
         /// <inheritdoc cref="INumberBase{TSelf}.One" />
-        static Half INumberBase<Half>.One => new Half(PositiveOneBits);
+        public static Half One => new Half(PositiveOneBits);
 
         /// <inheritdoc cref="INumberBase{TSelf}.Zero" />
-        static Half INumberBase<Half>.Zero => new Half(PositiveZeroBits);
+        public static Half Zero => new Half(PositiveZeroBits);
 
         //
         // IParsable
@@ -1527,7 +1561,7 @@ public static bool TryCreate<TOther>(TOther value, out Half result)
         //
 
         /// <inheritdoc cref="ISignedNumber{TSelf}.NegativeOne" />
-        static Half ISignedNumber<Half>.NegativeOne => new Half(NegativeOneBits);
+        public static Half NegativeOne => new Half(NegativeOneBits);
 
         //
         // ISpanParsable