Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d37d5e4
Make SString generic on an encoding traits type.
jkoritzinsky May 23, 2022
42fa6ab
Merge branch 'main' of github.com:dotnet/runtime into sstring-explici…
jkoritzinsky May 23, 2022
f913366
Fix linux build
jkoritzinsky May 24, 2022
32ddf53
Rename a few things to reduce the overall number of changes.
jkoritzinsky May 24, 2022
b2588e6
Fix linux build.
jkoritzinsky May 24, 2022
bc07888
A few more changes to reduce diffs.
jkoritzinsky May 24, 2022
8ebc5df
More diff reduction
jkoritzinsky May 24, 2022
0a5056c
Various fixes for SString. Reimplement the move semantics on SBuffer …
jkoritzinsky May 25, 2022
26f4944
Fix base type member usage with templates
jkoritzinsky May 26, 2022
824aa67
Store the result of GetPathToLoad in a local so we don't trash GetLas…
jkoritzinsky May 26, 2022
b146aae
Fix reuse bug in assembly loading.
jkoritzinsky May 27, 2022
e95cbef
Merge branch 'main' of github.com:dotnet/runtime into sstring-explici…
jkoritzinsky Jun 2, 2022
1a4d621
Merge branch 'sstring-explicit-encoding' of github.com:jkoritzinsky/r…
jkoritzinsky Jun 2, 2022
7b87012
Remove outdated comment
jkoritzinsky Jun 2, 2022
a7dcfad
Fix unix build
jkoritzinsky Jun 2, 2022
c445d35
Fix immutable empty shortcut and additional cleanup.
jkoritzinsky Jun 6, 2022
84876d8
Add static_assert message
jkoritzinsky Jun 6, 2022
2f01a7a
Fix cast issue on 32-bit
jkoritzinsky Jun 7, 2022
5aa2896
Fix default constructor to correctly mark UTF8/ASCII default EStrings…
jkoritzinsky Jun 7, 2022
b4d2fbd
Various fixes
jkoritzinsky Jun 7, 2022
bcfd0b7
Fix canary and buffer sharing handling. Fix another constructor that …
jkoritzinsky Jun 8, 2022
5a22849
Merge branch 'main' into sstring-explicit-encoding
jkoritzinsky Jun 8, 2022
7523a1f
Fix build break
jkoritzinsky Jun 9, 2022
a6fc06d
Fix super-large array rank error case handling.
jkoritzinsky Jun 9, 2022
5f53cc7
Fix some typos from bad find-replace in nativeaot code
jkoritzinsky Jun 9, 2022
93e98cf
Merge branch 'main' of github.com:dotnet/runtime into sstring-explici…
jkoritzinsky Jun 14, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some typos from bad find-replace in nativeaot code
  • Loading branch information
jkoritzinsky committed Jun 9, 2022
commit 5f53cc74722e79fc1bc5e01ce2ab150fd127df28
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/BuildIntegration/WindowsAPIs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -956,8 +956,8 @@ kernel32!FindNextFileNameW
kernel32!FindNextFileW
kernel32!FindNextStreamW
kernel32!FindNextVolumeW
kernel32!FindNLEString
kernel32!FindNLEStringEx
kernel32!FindNLSString
kernel32!FindNLSStringEx
kernel32!FindResourceExW
kernel32!FindResourceW
kernel32!FindStringOrdinal
Expand Down
22 changes: 11 additions & 11 deletions src/coreclr/nativeaot/Runtime/eventtrace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ void BulkTypeEventLogger::FireBulkTypeEvent()
_ASSERTE(iDesc < _countof(EventData));
#ifdef FEATURE_NATIVEAOT
EventDataDescCreate(&EventData[iDesc++], L"", sizeof(WCHAR));
#else // FEATURE_REDHAWK
#else // FEATURE_NATIVEAOT
LPCWSTR wszName = (LPCWSTR)m_rgBulkTypeValues[iTypeData].sName;
EventDataDescCreate(
&EventData[iDesc++],
Expand Down Expand Up @@ -3828,7 +3828,7 @@ void ETW::ExceptionLog::ExceptionThrown(CrawlFrame* pCf, BOOL bIsReThrownExcepti
}
EX_TRY
{
EString exceptionType(L"");
SString exceptionType(L"");
LPWSTR exceptionMessage = NULL;
BOOL bIsCLSCompliant = FALSE, bIsCSE = FALSE, bIsNestedException = FALSE, bHasInnerException = FALSE;
UINT16 exceptionFlags = 0;
Expand Down Expand Up @@ -4169,7 +4169,7 @@ void ETW::InfoLog::RuntimeInformation(INT32 type)
/*******************************************************/
/* This is called by the runtime when a method is jitted completely */
/*******************************************************/
void ETW::MethodLog::MethodJitted(MethodDesc* pMethodDesc, EString* namespaceOrClassName, EString* methodName, EString* methodSignature, SIZE_T pCode, ReJITID rejitID)
void ETW::MethodLog::MethodJitted(MethodDesc* pMethodDesc, SString* namespaceOrClassName, SString* methodName, SString* methodSignature, SIZE_T pCode, ReJITID rejitID)
{
CONTRACTL{
NOTHROW;
Expand Down Expand Up @@ -4206,7 +4206,7 @@ void ETW::MethodLog::MethodJitted(MethodDesc* pMethodDesc, EString* namespaceOrC
/*************************************************/
/* This is called by the runtime when method jitting started */
/*************************************************/
void ETW::MethodLog::MethodJitting(MethodDesc* pMethodDesc, EString* namespaceOrClassName, EString* methodName, EString* methodSignature)
void ETW::MethodLog::MethodJitting(MethodDesc* pMethodDesc, SString* namespaceOrClassName, SString* methodName, SString* methodSignature)
{
CONTRACTL{
NOTHROW;
Expand Down Expand Up @@ -4850,7 +4850,7 @@ void ETW::LoaderLog::SendAssemblyEvent(Assembly* pAssembly, DWORD dwEventOptions
(bHasNativeImage ? ETW::LoaderLog::LoaderStructs::NativeAssembly : 0) |
(bIsCollectibleAssembly ? ETW::LoaderLog::LoaderStructs::CollectibleAssembly : 0));

EString sAssemblyPath;
SString sAssemblyPath;
pAssembly->GetDisplayName(sAssemblyPath);
LPWSTR lpszAssemblyPath = (LPWSTR)(LPCWSTR)sAssemblyPath;

Expand Down Expand Up @@ -5209,9 +5209,9 @@ void ETW::LoaderLog::SendModuleEvent(Module* pModule, DWORD dwEventOptions, BOOL

LPCWSTR pEmptyString = L"";
#ifndef FEATURE_PAL
EString moduleName = L"";
SString moduleName = L"";
#else // !FEATURE_PAL
EString moduleName;
SString moduleName;
#endif // !FEATURE_PAL
if (!bIsDynamicAssembly)
{
Expand Down Expand Up @@ -5311,7 +5311,7 @@ void ETW::LoaderLog::SendModuleEvent(Module* pModule, DWORD dwEventOptions, BOOL
/*****************************************************************/
/* This routine is used to send an ETW event just before a method starts jitting*/
/*****************************************************************/
void ETW::MethodLog::SendMethodJitStartEvent(MethodDesc* pMethodDesc, EString* namespaceOrClassName, EString* methodName, EString* methodSignature)
void ETW::MethodLog::SendMethodJitStartEvent(MethodDesc* pMethodDesc, SString* namespaceOrClassName, SString* methodName, SString* methodSignature)
{
CONTRACTL{
THROWS;
Expand Down Expand Up @@ -5366,7 +5366,7 @@ void ETW::MethodLog::SendMethodJitStartEvent(MethodDesc* pMethodDesc, EString* n
ulMethodILSize = (ULONG)ILHeader.GetCodeSize();
}

EString tNamespace, tMethodName, tMethodSignature;
SString tNamespace, tMethodName, tMethodSignature;
if (!namespaceOrClassName || !methodName || !methodSignature || (methodName->IsEmpty() && namespaceOrClassName->IsEmpty() && methodSignature->IsEmpty()))
{
pMethodDesc->GetMethodInfo(tNamespace, tMethodName, tMethodSignature);
Expand Down Expand Up @@ -5408,7 +5408,7 @@ void ETW::MethodLog::SendMethodJitStartEvent(MethodDesc* pMethodDesc, EString* n
/****************************************************************************/
/* This routine is used to send a method load/unload or rundown event */
/****************************************************************************/
void ETW::MethodLog::SendMethodEvent(MethodDesc* pMethodDesc, DWORD dwEventOptions, BOOL bIsJit, EString* namespaceOrClassName, EString* methodName, EString* methodSignature, SIZE_T pCode, ReJITID rejitID)
void ETW::MethodLog::SendMethodEvent(MethodDesc* pMethodDesc, DWORD dwEventOptions, BOOL bIsJit, SString* namespaceOrClassName, SString* methodName, SString* methodSignature, SIZE_T pCode, ReJITID rejitID)
{
CONTRACTL{
THROWS;
Expand Down Expand Up @@ -5534,7 +5534,7 @@ void ETW::MethodLog::SendMethodEvent(MethodDesc* pMethodDesc, DWORD dwEventOptio
ulColdMethodSize = (ULONG)methodRegionInfo.coldSize; // methodRegionInfo.coldSize is size_t and info.MethodLoadInfo.MethodSize is 32 bit; will give incorrect values on a 64-bit machine
}

EString tNamespace, tMethodName, tMethodSignature;
SString tNamespace, tMethodName, tMethodSignature;

// if verbose method load info needed, only then
// find method name and signature and fire verbose method load info
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime/eventtracepriv.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// clients of eventtrace.cpp, and thus don't belong in eventtrace.h. Also, since
// inclusions of this file are tightly controlled (basically just by eventtrace.cpp), we
// can assume some classes are defined that aren't necessarily defined when eventtrace.h
// is #included (e.g., StackEString and StackSArray).
// is #included (e.g., StackSString and StackSArray).
//
// ============================================================================

Expand Down