Skip to content

Store actual signature types in CallArg and normalize to that type #69969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
May 31, 2022
Merged

Store actual signature types in CallArg and normalize to that type #69969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,20 +861,6 @@ void Compiler::impPopCallArgs(CORINFO_SIG_INFO* sig, GenTreeCall* call)
// Morph trees that aren't already OBJs or MKREFANY to be OBJs
assert(ti.IsType(TI_STRUCT));

// The argument and parameter types can be different for legitimate
// reasons, but we expect them to be compatible in those cases. One
// example where this happens is when inlining shared code into a
// non-generic function, in which case we might see the __Canon in
// the parameter type but exact types in the signature type.
//
// TODO-ARGS: Remove this quirk; we should be able to use the
// signature type that is different in the rare case above. It will
// cause positive diffs, but that is probably an indication that we
// have downstream phases that should be using
// `ClassLayout::AreCompatible` instead.
//
classHnd = ti.GetClassHandleForValueClass();

bool forceNormalization = false;
if (varTypeIsSIMD(argNode))
{
Expand Down