Skip to content

Use the signature's struct handle for making outgoing arg copies #69971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 2 commits into from
May 30, 2022
Merged

Use the signature's struct handle for making outgoing arg copies #69971

jakobbotsch merged 2 commits into from
May 30, 2022

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 29, 2022 •
edited
Loading

No diffs as expected.

Fixes #69965.

@SingleAccretion
Do not depend on class handle in "fgMorphArgs"
1b5ed32 
Use the signature's handle when making an outgoing arg copy.
@SingleAccretion
Add a test
10ca1ef
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 29, 2022
@ghost
Copy link

ghost commented May 29, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion changed the title Use the signature struct handle for making outgoing arg copies Use the signature's struct handle for making outgoing arg copies May 29, 2022
@jakobbotsch
Copy link
Member

jakobbotsch commented May 29, 2022

Nice, that's one follow-up to #68748 I can cross off my todo-list :-)

@SingleAccretion SingleAccretion marked this pull request as ready for review May 29, 2022 23:00
jakobbotsch
jakobbotsch approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakobbotsch jakobbotsch merged commit 486b4d1 into dotnet:main May 30, 2022
@SingleAccretion SingleAccretion deleted the Use-SigClass-In-fgMorphArgs branch May 30, 2022 10:47
@SingleAccretion SingleAccretion mentioned this pull request May 30, 2022
Merged
@tannergooding tannergooding mentioned this pull request May 31, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

impNormStructVal's OBJ(ADDR(LCL_VAR)) wrapping logic can be too permissive

2 participants

@SingleAccretion @jakobbotsch