Skip to content

[mono] Enable -Werror=shorten-64-to-32 #70062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lambdageek wants to merge 17 commits into from
Closed

[mono] Enable -Werror=shorten-64-to-32 #70062

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6c29b7c
Reenable 4244 warning for Mono.
AaronRobinsonMSFT May 31, 2022
2e6f9d1
Enable compiler errors for gcc/clang.
AaronRobinsonMSFT Jun 1, 2022
adcceba
Fix issues enabling -Werror=implicit-int-conversion
AaronRobinsonMSFT Jun 1, 2022
d8e76bb
[mono] use -Werror=shorten-64-to-32 and -Werror=implicit-int-conversion
lambdageek Jun 1, 2022
ae39210
fix all -Wshorten-64-to-32 errors on x64
lambdageek Jun 1, 2022
4932b06
Turn off warnings-as-errors for zlib
lambdageek Jun 1, 2022
7a00c7b
Don't set -Werror=implicit-int-conversion with GCC
lambdageek Jun 1, 2022
00715cb
fix osx shorten-64-to-32
lambdageek Jun 1, 2022
5e0c071
fix arm64 shorten-64-to-32
lambdageek Jun 1, 2022
5862e6a
llvm fix -Wshorten-64-to-32
lambdageek Jun 1, 2022
7d3a1d9
linux-arm64 fix -Wshorten-64-to-32
lambdageek Jun 1, 2022
f7649d7
osx fixup
lambdageek Jun 1, 2022
93eabbd
turn off warnings for mono mscordbi and dbgshim
lambdageek Jun 1, 2022
c6050b8
fix osx-x64
lambdageek Jun 1, 2022
8bfb629
fix tvos
lambdageek Jun 1, 2022
f77b9b2
Update src/mono/mono/metadata/icall-eventpipe.c
lambdageek Jun 1, 2022
24f067e
Update src/mono/mono/metadata/icall-eventpipe.c
lambdageek Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable compiler errors for gcc/clang.
  • Loading branch information
@AaronRobinsonMSFT
AaronRobinsonMSFT committed Jun 1, 2022
commit 2e6f9d1cb4875cf8168b20454498f89419457c7a
7 changes: 4 additions & 3 deletions src/mono/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,13 +502,14 @@ if(GCC)
set(WARNINGS "-Wall -Wunused -Wmissing-declarations -Wpointer-arith -Wno-cast-qual -Wwrite-strings -Wno-switch -Wno-switch-enum -Wno-unused-value -Wno-attributes -Wno-format-zero-length -Wno-unused-function")
set(WARNINGS_C "-Wmissing-prototypes -Wstrict-prototypes -Wnested-externs")

set(WERROR "-Werror=return-type")
set(WERROR_C "-Werror=implicit-function-declaration -Werror=implicit-int-conversion")

if (CMAKE_C_COMPILER_ID MATCHES "Clang")
set(WARNINGS "${WARNINGS} -Qunused-arguments -Wno-tautological-compare -Wno-parentheses-equality -Wno-self-assign -Wno-return-stack-address -Wno-constant-logical-operand -Wno-zero-length-array -Wno-asm-operand-widths")
set(WERROR "${WERROR} -Werror=shorten-64-to-32")
endif()

set(WERROR "-Werror=return-type")
set(WERROR_C "-Werror=implicit-function-declaration")

check_c_compiler_flag("-Werror=incompatible-pointer-types" WERROR_INCOMPATIBLE_POINTER_TYPES)
if(WERROR_INCOMPATIBLE_POINTER_TYPES)
set(WERROR_C "${WERROR_C} -Werror=incompatible-pointer-types")
Expand Down