[release/7.0-preview5] Make gcunsafe for cpblk if it has gc pointers #70069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #70053 to release/7.0-preview5 /cc @kunalspathak Customer ImpactTestingRiskIMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Contributor
|
Failures are related to #68837 |
Contributor
|
@dotnet/jit-contrib |
jakobbotsch
approved these changes
Jun 1, 2022
Member
|
cc @jeffschwMSFT for servicing to PR5. |
jeffschwMSFT
approved these changes
Jun 1, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We should take for consideration in preview 5.
carlossanlop
added
Servicing-approved
Contributor
|
Approved by Tactics via email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #70053 to release/7.0-preview5
/cc @kunalspathak
Customer Impact
There was a bug where we would not mark a region as non-interruptible because it created references in registers that were not reported to GC. As such, if the GC kicks in, it will sporadically move non-GC pointers leading to crash or wrong behavior of the program.
Testing
Existing test coverage.
Risk
The bug was introduced with one of the refactoring changes and this PR just puts back those changes that were missed out.