Skip to content

Convert exception help context parsing to managed #70251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 15 commits into from
Jun 14, 2022
Merged

Convert exception help context parsing to managed #70251

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b7c564d
Move help link parsing to managed
huoyaoyuan Jun 4, 2022
359faf3
Cleanup wtoi and nativeIsDigit
huoyaoyuan Jun 4, 2022
0fa60f5
Fix metasig declaration
huoyaoyuan Jun 5, 2022
1be1d90
Guard GetHelpContext under FEATURE_COMINTEROP
huoyaoyuan Jun 9, 2022
63ed0c0
Merge branch 'main' into exception-help-link
huoyaoyuan Jun 9, 2022
1afacf7
Remove definition of GetHelpLink and guard more methods under cominterop
huoyaoyuan Jun 9, 2022
ac53393
DWORD should be uint
huoyaoyuan Jun 9, 2022
1c357ef
Add help context marshaling test
huoyaoyuan Jun 9, 2022
ab2814f
Adjust marshaling test
huoyaoyuan Jun 10, 2022
b895def
Fix #ifdef with ILLink
huoyaoyuan Jun 11, 2022
4676d93
Fix method signature mismatch
huoyaoyuan Jun 13, 2022
70bd670
Specify string marshaling
huoyaoyuan Jun 13, 2022
e896e23
Throwing test should not test successful HRESULT
huoyaoyuan Jun 13, 2022
0d4e385
Implement ISupportErrorInfo
huoyaoyuan Jun 13, 2022
8fc7de6
Test interface in InterfaceSupportsErrorInfo
huoyaoyuan Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix #ifdef with ILLink
  • Loading branch information
@huoyaoyuan
huoyaoyuan committed Jun 11, 2022
commit b895defa3033cfb9a4a526d3a4c954ad44e2a8d8
3 changes: 1 addition & 2 deletions src/coreclr/vm/corelib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,11 @@ DEFINE_FIELD_U(_xcode, ExceptionObject, _xcode)
DEFINE_FIELD_U(_HResult, ExceptionObject, _HResult)
DEFINE_CLASS(EXCEPTION, System, Exception)
DEFINE_METHOD(EXCEPTION, INTERNAL_PRESERVE_STACK_TRACE, InternalPreserveStackTrace, IM_RetVoid)
#ifdef FEATURE_COMINTEROP
// Following Exception members are only used when FEATURE_COMINTEROP
DEFINE_METHOD(EXCEPTION, GET_CLASS_NAME, GetClassName, IM_RetStr)
DEFINE_PROPERTY(EXCEPTION, MESSAGE, Message, Str)
DEFINE_PROPERTY(EXCEPTION, SOURCE, Source, Str)
DEFINE_METHOD(EXCEPTION, GET_HELP_CONTEXT, GetHelpContext, IM_RefInt_RetStr)
#endif


DEFINE_CLASS(SYSTEM_EXCEPTION, System, SystemException)
Expand Down