Skip to content

Fix ILGenerator maxstack computation #70388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 6 commits into from
Jun 22, 2022
Merged

Fix ILGenerator maxstack computation #70388

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0ba1b6
Fix ILGenerator maxstack computation
panguye May 27, 2022
aa31c31
Fix System.Linq.Expressions tests
panguye Jun 8, 2022
8c22d32
Suppress Emit5 tests in mono
panguye Jun 8, 2022
5ee8789
Merge branch 'dotnet:main' into issue-63805
panguye Jun 21, 2022
8d55541
Remove stack handling in MethodBuilder
panguye Jun 22, 2022
89cd1fa
retrigger checks
panguye Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress Emit5 tests in mono
  • Loading branch information
@panguye
panguye committed Jun 8, 2022
commit 8c22d3201507a082e4472ca8911ce5e11d4ab590
5 changes: 5 additions & 0 deletions src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit5Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests
public class ILGeneratorEmit5
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63805", TestRuntimes.Mono)]
public void MaxStackOverflowTest()
{
Run(1 << 5);
Expand Down Expand Up @@ -76,6 +77,7 @@ static MethodInfo GetCode(int num)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63805", TestRuntimes.Mono)]
public void MaxStackNonEmptyForward()
{
// This test uses forward branches to "new" basic blocks where the stack depth
Expand Down Expand Up @@ -139,6 +141,7 @@ static MethodInfo GetCode(int num)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63805", TestRuntimes.Mono)]
public void MaxStackNonEmptyBackward()
{
// This test uses backward branches to "new" basic blocks where the stack depth
Expand Down Expand Up @@ -212,6 +215,7 @@ static MethodInfo GetCode(int num)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63805", TestRuntimes.Mono)]
public void AmbiguousDepth()
{
var meth = GetCode();
Expand Down Expand Up @@ -258,6 +262,7 @@ static MethodInfo GetCode()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63805", TestRuntimes.Mono)]
public void UnreachableDepth()
{
var meth = GetCode();
Expand Down