Delete a zero-diff quirk and update INDEX-related comments
#70398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFollowing up on #69917. We're expecting some CSE-induced diffs in test code.
|
SingleAccretion
changed the title
INDEX-related comments
SingleAccretion
force-pushed
the
Arr-Addr-Index-Delete-Quirk-Upstream
branch
from
efa585d to
0237c07
Compare
Removing GT_INDEX/ADDR(IND) references.
SingleAccretion
force-pushed
the
Arr-Addr-Index-Delete-Quirk-Upstream
branch
from
0237c07 to
eb8528d
Compare
Contributor
Author
|
Will assume the
@dotnet/jit-contrib |
BruceForstall
approved these changes
Jun 8, 2022
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Thanks for the comment updates!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #69917.
We're expecting a small number of CSE-induced diffs in test code. These are (mostly) regressions because without the quirk we lose the
INDpart of an unused index indirection, thus losing the ability to CSE it together with other, used, index indirections. There is no easy fix for this issue, and I do not think it is worth keeping the quirk around for the couple of tests which hit it.Diffs.