Skip to content

Fix usage of GSS_KRB5_CRED_NO_CI_FLAGS_X #70447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 5 commits into from
Jun 14, 2022
Merged

Fix usage of GSS_KRB5_CRED_NO_CI_FLAGS_X #70447

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
023ec28
Fix build detection of GSS_KRB5_CRED_NO_CI_FLAGS_X
filipnavara Jun 8, 2022
3490f24
Don't use GSS_KRB5_CRED_NO_CI_FLAGS_X on NTLM
filipnavara Jun 8, 2022
2f3e77c
Handle GSS_S_UNAVAILABLE error from gss_set_cred_option (NTLM wrapped…
filipnavara Jun 8, 2022
65b5ef7
Make the GSSAPI shim work with krb5 1.13
filipnavara Jun 9, 2022
2f7906a
Preserve the gss_acquire_cred minor status
filipnavara Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Preserve the gss_acquire_cred minor status
  • Loading branch information
@filipnavara
filipnavara authored Jun 9, 2022
commit 2f7906ac8737612cf4798c1aab9fa4b785b92741
6 changes: 4 additions & 2 deletions src/native/libs/System.Net.Security.Native/pal_gssapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,9 @@ static uint32_t AcquireCredSpNego(uint32_t* minorStatus,
GssBuffer emptyBuffer = GSS_C_EMPTY_BUFFER;
uint32_t tempMinorStatus;
majorStatus = gss_set_cred_option(&tempMinorStatus, outputCredHandle, GSS_KRB5_CRED_NO_CI_FLAGS_X, &emptyBuffer);
if (majorStatus == GSS_S_UNAVAILABLE)
if (majorStatus == GSS_S_UNAVAILABLE || majorStatus == GSS_S_COMPLETE)
{
// preserve the original majorStatus/minorStatus from gss_acquire_cred
majorStatus = GSS_S_COMPLETE;
}
else
Expand Down Expand Up @@ -640,8 +641,9 @@ static uint32_t AcquireCredWithPassword(uint32_t* minorStatus,
GssBuffer emptyBuffer = GSS_C_EMPTY_BUFFER;
uint32_t tempMinorStatus;
majorStatus = gss_set_cred_option(&tempMinorStatus, outputCredHandle, GSS_KRB5_CRED_NO_CI_FLAGS_X, &emptyBuffer);
if (majorStatus == GSS_S_UNAVAILABLE)
if (majorStatus == GSS_S_UNAVAILABLE || majorStatus == GSS_S_COMPLETE)
{
// preserve the original majorStatus/minorStatus from gss_acquire_cred_with_password
majorStatus = GSS_S_COMPLETE;
}
else
Expand Down