Skip to content

JIT: Optimize expansion of indir cell addresses for CFG #70491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 4 commits into from
Jun 13, 2022
+69 −25
Merged

JIT: Optimize expansion of indir cell addresses for CFG #70491

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b7ff39
JIT: Optimize expansion of indir cell addresses for CFG
jakobbotsch Jun 9, 2022
8fc46d3
Fix GetIndirectionCellArgKind for delegates
jakobbotsch Jun 9, 2022
6ef03b4
Revert ARM LSRA changes
jakobbotsch Jun 10, 2022
e24f203
Merge branch 'main' of github.com:dotnet/runtime into cfg-optimize-in…
jakobbotsch Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix GetIndirectionCellArgKind for delegates 
These are actual invocations of the Invoke method so they have the
normal flags/entrypoints set, but we do not add indirection cells for
them.
  • Loading branch information
@jakobbotsch
jakobbotsch committed Jun 9, 2022
commit 8fc46d3047ae2ba43b7a1c79f9ed02521d8fba10
2 changes: 1 addition & 1 deletion src/coreclr/jit/gentree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5308,7 +5308,7 @@ struct GenTreeCall final : public GenTree

#if defined(TARGET_ARMARCH)
// For ARM architectures, we always use an indirection cell for R2R calls.
if (IsR2RRelativeIndir())
if (IsR2RRelativeIndir() && !IsDelegateInvoke())
{
return WellKnownArg::R2RIndirectionCell;
}
Expand Down