Skip to content

ConfigurationBinder.Bind on virtual properties duplicates elements #70592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 7 commits into from
Jun 14, 2022
Merged

ConfigurationBinder.Bind on virtual properties duplicates elements #70592

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
074e27e
ConfigurationBinder.Bind on virtual properties duplicates elements
pedrobsaila Jun 10, 2022
641f6a8
simplify condition
pedrobsaila Jun 10, 2022
e108f9c
use hashset instead of exists
pedrobsaila Jun 10, 2022
4262980
be less specific on BindingFlags
pedrobsaila Jun 13, 2022
c0fd61f
simplify GetAllProperties
pedrobsaila Jun 13, 2022
1444960
fix indentation
pedrobsaila Jun 13, 2022
21f140a
return array instead of list
pedrobsaila Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify GetAllProperties
  • Loading branch information
@pedrobsaila
pedrobsaila committed Jun 13, 2022
commit c0fd61fdd3152ca209c2b0ee17d0f137c26711a4
33 changes: 1 addition & 32 deletions src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,38 +755,7 @@ private static bool IsArrayCompatibleReadOnlyInterface(Type type)
private static List<PropertyInfo> GetAllProperties(
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)]
Type type)
{
var allProperties = new List<PropertyInfo>();
HashSet<string>? propertyNames = null;

Type? baseType = type;
do
{
PropertyInfo[] baseTypeProperties = baseType!.GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static);

if (baseType != type)
{
foreach (var property in baseTypeProperties)
{
if (propertyNames!.Add(property.Name))
{
allProperties.Add(property);
}
}
}
else
{
propertyNames = new(baseTypeProperties.Select(mp => mp.Name),
StringComparer.Ordinal);
allProperties.AddRange(baseTypeProperties);
}

baseType = baseType.BaseType;
}
while (baseType != typeof(object));

return allProperties;
}
=> type.GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static).ToList();

[RequiresUnreferencedCode(PropertyTrimmingWarningMessage)]
private static object? BindParameter(ParameterInfo parameter, Type type, IConfiguration config,
Expand Down