Skip to content

Implement Marshal.Get(Last)PInvokeErrorMessage() APIs. #70685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 7 commits into from
Jun 24, 2022
Merged

Implement Marshal.Get(Last)PInvokeErrorMessage() APIs. #70685

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55959cf
Implement Marshal.GetPInvokeErrorMessage() API.
AaronRobinsonMSFT Jun 13, 2022
1308eb2
Invert the implementation for Win32Exception and move the
AaronRobinsonMSFT Jun 13, 2022
45161d3
Add additional testing.
AaronRobinsonMSFT Jun 13, 2022
1979b4c
Handle unknown error codes on linux.
AaronRobinsonMSFT Jun 14, 2022
c37247c
Condition usage of new API for NET7+.
AaronRobinsonMSFT Jun 14, 2022
f498fcc
Added additional GetLastPInvokeErrorMessage() API
AaronRobinsonMSFT Jun 23, 2022
41872ed
Apply suggestions from code review
AaronRobinsonMSFT Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@AaronRobinsonMSFT
AaronRobinsonMSFT authored Jun 24, 2022
commit 41872ed12f3f08249e629bf0b7cd26181eb7f625
2 changes: 1 addition & 1 deletion ...raries/System.Security.Principal.Windows/src/System/Security/Principal/WindowsIdentity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ private static Exception GetExceptionFromNtStatus(int status)
return new OutOfMemoryException();

uint win32ErrorCode = Interop.Advapi32.LsaNtStatusToWinError((uint)status);
return new SecurityException(Marshal.GetPInvokeErrorMessage(unchecked((int)win32ErrorCode)));
return new SecurityException(Marshal.GetPInvokeErrorMessage((int)win32ErrorCode));
}

private static SafeAccessTokenHandle GetCurrentToken(TokenAccessLevels desiredAccess, bool threadOnly, out bool isImpersonating, out int hr)
Expand Down