-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[wasm] Make runtime_is_initialized promise callbacks one-shot #70694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a slightly generalized GuardedPromise<T> object
Protects against multiple-resolve, multiple-reject, reject after resolve and resolve after reject. Does not protect against the executor throwing.
- Loading branch information
commit 1d869778061b8a70ce94d51dd09e8194f450c053
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /// A Promise<T> that guards against multiple-resolve, multiple-reject, reject-after-accept and accept-after-reject. | ||
| class GuardedPromise<T> extends Promise<T> { | ||
| constructor(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void) { | ||
| super((resolve, reject) => { | ||
| let resolved = false; | ||
| let rejected = false; | ||
| executor((value: T | PromiseLike<T>) => { | ||
| if (resolved) { | ||
| throw new Error("Promise resolved more than once"); | ||
| } | ||
| if (rejected) { | ||
| throw new Error("Can not resolve a Promise after it has been rejected"); | ||
| } | ||
| resolved = true; | ||
| resolve(value); | ||
| }, (reason: any) => { | ||
| if (resolved) { | ||
| throw new Error("Can not reject a Promise after it has been resolved"); | ||
| } | ||
| if (rejected) { | ||
| throw new Error("Promise rejected more than once"); | ||
| } | ||
| rejected = true; | ||
| reject(reason); | ||
| }); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| export default GuardedPromise; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.