Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a slightly generalized GuardedPromise<T> object
Protects against multiple-resolve, multiple-reject, reject after resolve and
 resolve after reject.

 Does not protect against the executor throwing.
  • Loading branch information
lambdageek committed Jun 14, 2022
commit 1d869778061b8a70ce94d51dd09e8194f450c053
31 changes: 31 additions & 0 deletions src/mono/wasm/runtime/guarded-promise.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/// A Promise<T> that guards against multiple-resolve, multiple-reject, reject-after-accept and accept-after-reject.
class GuardedPromise<T> extends Promise<T> {
constructor(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void) {
super((resolve, reject) => {
let resolved = false;
let rejected = false;
executor((value: T | PromiseLike<T>) => {
if (resolved) {
throw new Error("Promise resolved more than once");
}
if (rejected) {
throw new Error("Can not resolve a Promise after it has been rejected");
}
resolved = true;
resolve(value);
}, (reason: any) => {
if (resolved) {
throw new Error("Can not reject a Promise after it has been resolved");
}
if (rejected) {
throw new Error("Promise rejected more than once");
}
rejected = true;
reject(reason);
});
});
}
}

export default GuardedPromise;

20 changes: 4 additions & 16 deletions src/mono/wasm/runtime/startup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { AllAssetEntryTypes, mono_assert, AssetEntry, CharPtrNull, DotnetModule,
import { ENVIRONMENT_IS_ESM, ENVIRONMENT_IS_NODE, ENVIRONMENT_IS_SHELL, INTERNAL, locateFile, Module, MONO, requirePromise, runtimeHelpers } from "./imports";
import cwraps from "./cwraps";
import { mono_wasm_raise_debug_event, mono_wasm_runtime_ready } from "./debug";
import GuardedPromise from "./guarded-promise";
import { mono_wasm_globalization_init, mono_wasm_load_icu_data } from "./icu";
import { toBase64StringImpl } from "./base64";
import { mono_wasm_init_aot_profiler, mono_wasm_init_coverage_profiler } from "./profiler";
Expand All @@ -17,24 +18,11 @@ import { mono_on_abort } from "./run";
import { mono_wasm_new_root } from "./roots";
import { init_crypto } from "./crypto-worker";

/// Given a function name (for diagnostic purposes) and a function, returns a function that invokes the original function
/// the first time it is called, and otherwise throws an exception.
function oneShot<T extends any[], TRes>(name: string, f: (...args: [...T]) => TRes): (...args: [...T]) => TRes {
let wasCalled = false;
function guardedF(...args: [...T]): TRes {
if (wasCalled)
throw new Error(`${name} called more than once`);
wasCalled = true;
return f(...args);
}
return guardedF;
}

export let runtime_is_initialized_resolve: () => void;
export let runtime_is_initialized_reject: (reason?: any) => void;
export const mono_wasm_runtime_is_initialized = new Promise<void>((resolve, reject) => {
runtime_is_initialized_resolve = oneShot("resolve", resolve);
runtime_is_initialized_reject = oneShot("reject", reject);
export const mono_wasm_runtime_is_initialized = new GuardedPromise<void>((resolve, reject) => {
runtime_is_initialized_resolve = resolve;
runtime_is_initialized_reject = reject;
});

let ctx: DownloadAssetsContext | null = null;
Expand Down