Skip to content

VM: Better strategy for TryReserveInitialMemory on arm64 (jump stubs) #70707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 16 commits into from
Jun 22, 2022
+29 −8
Merged

VM: Better strategy for TryReserveInitialMemory on arm64 (jump stubs) #70707

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
704b749
Better strategy for ReserveInitialMemory on arm64
EgorBo Jun 14, 2022
335e3cc
Merge branch 'main' of github.com:dotnet/runtime into yet-another-fix…
EgorBo Jun 14, 2022
d252971
Clean up
EgorBo Jun 14, 2022
f9fb6ac
Merge branch 'main' of github.com:dotnet/runtime into yet-another-fix…
EgorBo Jun 15, 2022
5897d6d
Address feedback
EgorBo Jun 15, 2022
6d0cdf1
fix "below" case
EgorBo Jun 15, 2022
1fc5970
Merge branch 'main' of github.com:dotnet/runtime into yet-another-fix…
EgorBo Jun 16, 2022
909cf7c
Address feedback
EgorBo Jun 16, 2022
db57294
Update virtual.cpp
EgorBo Jun 16, 2022
a5c76a3
Apply suggestions from code review
EgorBo Jun 16, 2022
c9e36ed
Address feedback
EgorBo Jun 16, 2022
eab1661
Fix defines
EgorBo Jun 16, 2022
42b0ed6
Remove env var
EgorBo Jun 21, 2022
5ddfd68
clean up
EgorBo Jun 21, 2022
168fe20
Clean up
EgorBo Jun 21, 2022
94146e2
Update virtual.h
EgorBo Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix defines
  • Loading branch information
@EgorBo
EgorBo committed Jun 16, 2022
commit eab1661e7894c8691dd6b022fdde5f2a38b2fd14
4 changes: 2 additions & 2 deletions src/coreclr/pal/src/map/virtual.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2142,7 +2142,7 @@ void ExecutableMemoryAllocator::TryReserveInitialMemory()
UINT_PTR preferredStartAddress;
UINT_PTR coreclrLoadAddress;

#ifdef TARGET_ARMARCH
#if defined(TARGET_ARM) || defined(TARGET_ARM64)
// Smaller steps on ARM because we try hard finding a spare memory in a 128Mb
// distance from coreclr so e.g. all calls from corelib to coreclr could use relocs
const int32_t AddressProbingIncrement = 8 * 1024 * 1024;
Expand Down Expand Up @@ -2175,7 +2175,7 @@ void ExecutableMemoryAllocator::TryReserveInitialMemory()
else
{
// Try to allocate below the location of libcoreclr
#ifdef TARGET_ARMARCH
#if defined(TARGET_ARM) || defined(TARGET_ARM64)
// For arm for the "high address" case it only makes sense to try to reserve 128Mb
// and if it doesn't work - we'll reserve a full-sized region in a random location
sizeOfAllocation = SizeProbingDecrement;
Expand Down