Skip to content

Enable fake hot/cold splitting on ARM64 #70708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanasifkhalid merged 13 commits into from
Jun 22, 2022
Merged

Enable fake hot/cold splitting on ARM64 #70708

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
671c81a
Add hot/cold splitting test job to jit-runtime-experimental
May 27, 2022
60ad816
Implement branching between hot/cold sections on ARM64.
Jun 1, 2022
7989a93
Implement branching between hot/cold sections on ARM64
Jun 8, 2022
d2bbed8
Enable fake hot/cold splitting on ARM64
Jun 14, 2022
17b8c48
Merge branch 'dotnet:main' into code-splitting-arm
amanasifkhalid Jun 14, 2022
fb5b078
Enable fake hot/cold splitting on ARM64
Jun 14, 2022
0e7018e
Merge branch 'code-splitting-arm' of https://github.com/amanasifkhali…
Jun 14, 2022
b61a94a
Fix regression in runtime-jit-experimental
Jun 15, 2022
d208b3a
Merge branch 'hot-cold-splitting' of https://github.com/amanasifkhali…
Jun 16, 2022
8ed9046
Update fake-splitting implementation on ARM64
Jun 20, 2022
0493057
Merge branch 'dotnet:main' into code-splitting-arm
amanasifkhalid Jun 21, 2022
59dc5ed
merge
Jun 21, 2022
548b9a5
Disable hot/cold splitting on LoongArch64
Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8437,7 +8437,8 @@ void emitter::emitIns_J(instruction ins, BasicBlock* dst, int instrCount)
{
case INS_bl_local:
idjShort = true;
// Fall through.
fmt = IF_BI_0A;
break;
case INS_b:
// Unconditional jump is a single form.
// Assume is long in case we cross hot/cold sections.
Expand Down Expand Up @@ -9840,6 +9841,9 @@ BYTE* emitter::emitOutputLJ(insGroup* ig, BYTE* dst, instrDesc* i)
// Special case: emit add + ld1 instructions for loading 16-byte data into vector register.
if (isVectorRegister(dstReg) && (opSize == EA_16BYTE))
{
// Low 4 bits should be 0 -- 16-byte JIT data should be aligned on 16 bytes.
assert((imm12 & 15) == 0);

const emitAttr elemSize = EA_1BYTE;
const insOpts opt = optMakeArrangement(opSize, elemSize);

Expand Down
1 change: 0 additions & 1 deletion src/tests/Common/testenvironment.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
COMPlus_EnableSSE42;
COMPlus_EnableSSSE3;
COMPlus_ForceRelocs;
COMPlus_GCgen0size;
COMPlus_GCStress;
COMPlus_GCName;
COMPlus_gcServer;
Expand Down