Skip to content

Implement Tar Global Extended Attributes API changes #70869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 8 commits into from
Jun 22, 2022
Merged

Implement Tar Global Extended Attributes API changes #70869

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37cfb52
ref: Global Extended Attributes API changes
carlossanlop Jun 17, 2022
4e11d92
src: Global Extended Attributes API changes
carlossanlop Jun 17, 2022
5279945
tests: Verify Global Extended Attributes API changes
carlossanlop Jun 17, 2022
aa9c213
Address suggestions
carlossanlop Jun 20, 2022
94315d3
Address debug suggestion.
carlossanlop Jun 22, 2022
5895408
Improve the decision of reducing the size of the GEA path.
carlossanlop Jun 22, 2022
df9e81d
Use Path.GetTempPath for the GEA path.
carlossanlop Jun 22, 2022
273394d
Rename field tracking GEA entry number.
carlossanlop Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve the decision of reducing the size of the GEA path.
  • Loading branch information
@carlossanlop
carlossanlop committed Jun 22, 2022
commit 589540883bc26a489601bc7d1a97e5e909b6fa9d
6 changes: 3 additions & 3 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,12 +627,12 @@ private static string GenerateGlobalExtendedAttributeName(int globalExtendedAttr
int processId = Environment.ProcessId;

string result = string.Format(GlobalHeadFormatPrefix, tmpDir, processId);
if (result.Length >= FieldLengths.Name)
string suffix = $".{globalExtendedAttributesEntryNumber}"; // GEA sequence number
if (result.Length + suffix.Length >= FieldLengths.Name)
{
result = string.Format(GlobalHeadFormatPrefix, "/tmp", processId);
}

result += $".{globalExtendedAttributesEntryNumber}"; // Suffix is ".{sequenceNumber}"
result += suffix;

return result;
}
Expand Down