-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Polyfill the incremental generator ForAttributeWithMetadataName from roslyn. #70911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+921
−38
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6e03dca
Add the initial roslyn files
CyrusNajmabadi 539b248
Merge remote-tracking branch 'upstream/main' into polyfill
CyrusNajmabadi e8f0a8e
IN progress
CyrusNajmabadi 1c0fbf2
Builds
CyrusNajmabadi b533f26
Use api
CyrusNajmabadi c1a76b1
ifdef
CyrusNajmabadi 2ef0717
Merge remote-tracking branch 'upstream/main' into polyfill
CyrusNajmabadi 1f35a7e
Move using outside namespace
CyrusNajmabadi f5d8137
Move to debug assert
CyrusNajmabadi be4ef0f
Optimize common cases
CyrusNajmabadi 2babd86
Merge remote-tracking branch 'upstream/main' into polyfill
CyrusNajmabadi 1cdc428
Explain if'defed regions
CyrusNajmabadi cfce553
Explain if'defed regions
CyrusNajmabadi fd9a27e
Update System.Text.RegularExpressions.Generator.csproj
CyrusNajmabadi e2613b6
Port latest changes over
CyrusNajmabadi a0e9d88
Merge branch 'polyfill' of https://github.com/CyrusNajmabadi/runtime …
CyrusNajmabadi 91672fe
Renames
CyrusNajmabadi 86de769
Merge branch 'main' into polyfill
CyrusNajmabadi cc933a2
Update src/libraries/Common/src/Roslyn/CSharpSyntaxHelper.cs
CyrusNajmabadi 8a5a8d0
Simplify
CyrusNajmabadi 4eb00d1
Dispose builders
CyrusNajmabadi 59cdea7
Dispose builders
CyrusNajmabadi e7a1f3e
Simplify by removing support for nested attributes
CyrusNajmabadi 20d62a2
Simplify
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Explain if'defed regions
- Loading branch information
commit 1cdc42866d610db2e1a71acff90fe0511a5e5fba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i was only referencing a tiny part of the surface area of the copied code, i
ifdefedout the rest to keep teh intrusion minimal. i kept the code in case we may need to access more of it. this allows the code to stay close in sync with teh roslyn version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add a comment above explaining this?