Skip to content

Make SuperPMI more explicit about JIT in error messages #70938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BruceForstall merged 1 commit into from
Jun 20, 2022
Merged

Make SuperPMI more explicit about JIT in error messages #70938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/coreclr/tools/superpmi/superpmi/superpmi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ int __cdecl main(int argc, char* argv[])
st3.Start();
res = jit->CompileMethod(mc, reader->GetMethodContextIndex(), collectThroughput, &baseMetrics);
st3.Stop();
LogDebug("Method %d compiled in %fms, result %d", reader->GetMethodContextIndex(), st3.GetMilliseconds(), res);
LogDebug("Method %d compiled%s in %fms, result %d",
reader->GetMethodContextIndex(), (o.nameOfJit2 == nullptr) ? "" : " by JIT1", st3.GetMilliseconds(), res);

totalBaseMetrics.AggregateFrom(baseMetrics);

Expand Down Expand Up @@ -406,8 +407,8 @@ int __cdecl main(int argc, char* argv[])
if (res2 == JitInstance::RESULT_ERROR)
{
errorCount2++;
LogError("Method %d of size %d failed to load and compile correctly by JIT2.",
reader->GetMethodContextIndex(), mc->methodSize);
LogError("Method %d of size %d failed to load and compile correctly by JIT2 (%s).",
reader->GetMethodContextIndex(), mc->methodSize, o.nameOfJit2);
if (errorCount2 == o.failureLimit)
{
LogError("More than %d methods compilation failed by JIT2. Skip compiling remaining methods.", o.failureLimit);
Expand Down Expand Up @@ -565,11 +566,13 @@ int __cdecl main(int argc, char* argv[])
if (res == JitInstance::RESULT_ERROR)
{
errorCount++;
LogError("main method %d of size %d failed to load and compile correctly.",
reader->GetMethodContextIndex(), mc->methodSize);
LogError("Method %d of size %d failed to load and compile correctly%s (%s).",
reader->GetMethodContextIndex(), mc->methodSize,
(o.nameOfJit2 == nullptr) ? "" : " by JIT1", o.nameOfJit);
if (errorCount == o.failureLimit)
{
LogError("More than %d methods failed. Skip compiling remaining methods.", o.failureLimit);
LogError("More than %d methods failed%s. Skip compiling remaining methods.",
o.failureLimit, (o.nameOfJit2 == nullptr) ? "" : " by JIT1");
break;
}
if ((o.reproName != nullptr) && (o.indexCount == -1))
Expand Down