Skip to content

Update design docs to reflect our new marshaller design from partner feedback #71017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 5 commits into from
Jun 23, 2022
Merged

Update design docs to reflect our new marshaller design from partner feedback #71017

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37b1aae
Update design docs to reflect our new marshaller design from partner …
jkoritzinsky Jun 20, 2022
3753304
Add comments about the optional methods
jkoritzinsky Jun 20, 2022
454107c
Apply suggestions from code review
jkoritzinsky Jun 21, 2022
488b0e3
Add a section showing usage of NativeMarshalling/MarshalUsing
jkoritzinsky Jun 22, 2022
443fdc7
Update docs/design/libraries/LibraryImportGenerator/UserTypeMarshalli…
jkoritzinsky Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Aaron Robinson <[email protected]>
  • Loading branch information
@jkoritzinsky @AaronRobinsonMSFT
jkoritzinsky and AaronRobinsonMSFT authored Jun 21, 2022
commit 454107c446f81b36b8d24241282525d29f0e3a2c
2 changes: 1 addition & 1 deletion docs/design/libraries/LibraryImportGenerator/Pipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ try
<< Pinned Marshal >>
<< Invoke >>
}
<< Keep Alive >>
<< Notify For Successful Invoke >>
<< Unmarshal Capture >>
<< Unmarshal >>
}
Expand Down
2 changes: 1 addition & 1 deletion docs/design/libraries/LibraryImportGenerator/SpanMarshallers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

As part of the exit criteria for the LibraryImportGenerator experiment, we have decided to introduce support for marshalling `System.Span<T>` and `System.ReadOnlySpan<T>` into the LibraryImportGenerator-generated stubs. This document describes design decisions made during the implementation of these marshallers.

> NOTE: These design docs are kept for historical purposes. The designs in this file are supersceded by the designs in [UserTypeMarshallingV2.md](UserTypeMarshallingV2.md).
> NOTE: These design docs are kept for historical purposes. The designs in this file are superseded by the designs in [UserTypeMarshallingV2.md](UserTypeMarshallingV2.md).

## Design 1: "Intrinsic" support for `(ReadOnly)Span<T>`

Expand Down
2 changes: 1 addition & 1 deletion docs/design/libraries/LibraryImportGenerator/StructMarshalling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ As part of the new source-generated direction for .NET Interop, we are looking a

These types pose an interesting problem for a number of reasons listed below. With a few constraints, I believe we can create a system that will enable users to use their own user-defined types and pass them by-value to native code.

> NOTE: These design docs are kept for historical purposes. The designs in this file are supersceded by the designs in [UserTypeMarshallingV2.md](UserTypeMarshallingV2.md).
> NOTE: These design docs are kept for historical purposes. The designs in this file are superseded by the designs in [UserTypeMarshallingV2.md](UserTypeMarshallingV2.md).

## Problems

Expand Down