Skip to content

Fix Tar timestamp conversion from/to string and DateTimeOffset #71038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 12 commits into from
Jun 23, 2022
Merged

Fix Tar timestamp conversion from/to string and DateTimeOffset #71038

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
529e4c0
Change double to decimal in timestamp conversions to preserve precision
carlossanlop Jun 21, 2022
d52a541
Re-enable disabled test
carlossanlop Jun 21, 2022
33974cd
Adjust assert message
carlossanlop Jun 21, 2022
9973fcd
Reuse FileSystemInfo Last*TimeUtc fields, use implicit cast operator …
carlossanlop Jun 21, 2022
c8df15b
Fix using wrong fieldname for ctime.
carlossanlop Jun 21, 2022
44789fc
Using 'G' for decimal to string conversion. Adjust test to not requir…
carlossanlop Jun 22, 2022
17e6060
Ensure timestamps are converted to long, not int.
carlossanlop Jun 22, 2022
9f81016
Add Epochalypse and Past-octal-limit timestamp tests
carlossanlop Jun 22, 2022
7fa8776
TarHelpers methods can be private
carlossanlop Jun 22, 2022
dc29c6b
Remove unreachable code for adding ctime and atime before writing Pax…
carlossanlop Jun 22, 2022
c7a0923
Fix typo in test when retrieving ctime.
carlossanlop Jun 22, 2022
cad5599
Make sure CTime adds nanoseconds on Unix when retrieving info from disk.
carlossanlop Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TarHelpers methods can be private
  • Loading branch information
@carlossanlop
carlossanlop committed Jun 22, 2022
commit 7fa87768f1f1ac59aff35f9a7d6f403a14c1baab
4 changes: 2 additions & 2 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ internal static DateTimeOffset GetDateTimeOffsetFromSecondsSinceEpoch(long secon
new DateTimeOffset((secondsSinceUnixEpoch * TimeSpan.TicksPerSecond) + DateTime.UnixEpoch.Ticks, TimeSpan.Zero);

// Converts the specified number of seconds that have passed since the Unix Epoch to a DateTimeOffset.
internal static DateTimeOffset GetDateTimeOffsetFromSecondsSinceEpoch(decimal secondsSinceUnixEpoch) =>
private static DateTimeOffset GetDateTimeOffsetFromSecondsSinceEpoch(decimal secondsSinceUnixEpoch) =>
new DateTimeOffset((long)(secondsSinceUnixEpoch * TimeSpan.TicksPerSecond) + DateTime.UnixEpoch.Ticks, TimeSpan.Zero);

// Converts the specified DateTimeOffset to the number of seconds that have passed since the Unix Epoch.
internal static decimal GetSecondsSinceEpochFromDateTimeOffset(DateTimeOffset dateTimeOffset) =>
private static decimal GetSecondsSinceEpochFromDateTimeOffset(DateTimeOffset dateTimeOffset) =>
((decimal)(dateTimeOffset.UtcDateTime - DateTime.UnixEpoch).Ticks) / TimeSpan.TicksPerSecond;

// If the specified fieldName is found in the provided dictionary and it is a valid decimal number, returns true and sets the value in 'dateTimeOffset'.
Expand Down