Skip to content

[wasm] Add Vector128.OnesComplement SIMD intrinsic #71384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radekdoulik merged 4 commits into from
Jun 28, 2022
Merged

[wasm] Add Vector128.OnesComplement SIMD intrinsic #71384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3599104
[wasm] Add Vector128.OnesComplement SIMD intrinsic
radekdoulik Jun 28, 2022
0d6c105
Apply feedback
radekdoulik Jun 28, 2022
48787ff
Add `--enable-simd` to `wasm-opt` again
radekdoulik Jun 28, 2022
afe297e
Fix build
radekdoulik Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/mono/mono/mini/mini-llvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11190,6 +11190,16 @@ MONO_RESTORE_WARNING
break;
}
#endif
#ifdef TARGET_WASM
case OP_WASM_ONESCOMPLEMENT: {
LLVMTypeRef i4v128_t = LLVMVectorType (i4_t, 4);
LLVMTypeRef ret_t = LLVMTypeOf (lhs);
LLVMValueRef cast = LLVMBuildBitCast (builder, lhs, i4v128_t, "");
LLVMValueRef result = LLVMBuildNot (builder, cast, "wasm_not");
values [ins->dreg] = LLVMBuildBitCast (builder, result, ret_t, "");
break;
}
#endif

case OP_DUMMY_USE:
break;
Expand Down
4 changes: 4 additions & 0 deletions src/mono/mono/mini/mini-ops.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,3 +1763,7 @@ MINI_OP3(OP_ARM64_SQRDMLSH_BYSCALAR, "arm64_sqrdmlsh_byscalar", XREG, XREG, XREG
MINI_OP3(OP_ARM64_SQRDMLSH_SCALAR, "arm64_sqrdmlsh_scalar", XREG, XREG, XREG, XREG)

#endif // TARGET_ARM64

#if defined(TARGET_WASM)
MINI_OP(OP_WASM_ONESCOMPLEMENT, "wasm_onescomplement", XREG, XREG, NONE)
#endif
8 changes: 8 additions & 0 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,14 @@ emit_simd_ins_for_unary_op (MonoCompile *cfg, MonoClass *klass, MonoMethodSignat
g_assert_not_reached ();
}
return emit_simd_ins_for_sig (cfg, klass, op, -1, arg_type, fsig, args);
#elif defined(TARGET_WASM)
switch (id)
{
case SN_OnesComplement:
return emit_simd_ins_for_sig (cfg, klass, OP_WASM_ONESCOMPLEMENT, -1, arg_type, fsig, args);
default:
return NULL;
}
#else
return NULL;
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/build/WasmApp.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@
</ItemGroup>

<Message Text="Stripping symbols from dotnet.wasm ..." Importance="High" Condition="'$(WasmNativeStrip)' == 'true'" />
<Exec Command="wasm-opt$(_ExeExt) --enable-exception-handling @(WasmOptConfigurationFlags, ' ') --strip-dwarf &quot;$(_WasmIntermediateOutputPath)dotnet.wasm&quot; -o &quot;$(_WasmIntermediateOutputPath)dotnet.wasm&quot;"
<Exec Command="wasm-opt$(_ExeExt) --enable-simd --enable-exception-handling @(WasmOptConfigurationFlags, ' ') --strip-dwarf &quot;$(_WasmIntermediateOutputPath)dotnet.wasm&quot; -o &quot;$(_WasmIntermediateOutputPath)dotnet.wasm&quot;"
Condition="'$(WasmNativeStrip)' == 'true'"
IgnoreStandardErrorWarningFormat="true"
EnvironmentVariables="@(EmscriptenEnvVars)" />
Expand Down