Skip to content

Unix arm64 atomics #71512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 10 commits into from
Jul 7, 2022
Merged

Unix arm64 atomics #71512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b20cf2a
Define_InterlockMethod macro
kunalspathak Jun 30, 2022
8ed7421
compiler failure
kunalspathak Jun 30, 2022
7ead20a
fix build errors
kunalspathak Jun 30, 2022
eb21958
Set g_arm64_atomics_present at common place
kunalspathak Jun 30, 2022
73ee366
Fix the missing declaration
kunalspathak Jul 1, 2022
71be17c
Change TARGET_ARM64 => HOST_ARM64
kunalspathak Jul 1, 2022
f927cf2
Use LSE for InterlockedCompareExchange
kunalspathak Jul 1, 2022
b0de604
Attempt to fix osx-arm64 build issue
kunalspathak Jul 4, 2022
800aa30
Introduce LSE_INSTRUCTIONS_ENABLED_BY_DEFAULT
kunalspathak Jul 4, 2022
fa2b92d
Make sure that compiler knows that M1 has lse
kunalspathak Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
compiler failure
  • Loading branch information
@kunalspathak
kunalspathak committed Jun 30, 2022
commit 8ed74219085d1473f5a856b8546fded1b3db05f3
2 changes: 1 addition & 1 deletion src/coreclr/pal/inc/pal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,7 @@ FORCEINLINE void PAL_ArmInterlockedOperationBarrier()
#endif
}

#if defined(HOST_ARM64)
#if defined(TARGET_ARM64)

#define Define_InterlockMethod(RETURN_TYPE, METHOD_DECL, METHOD_INVOC, INTRINSIC_NAME) \
__attribute__((target("lse"))) \
Expand Down
6 changes: 6 additions & 0 deletions src/coreclr/pal/src/init/pal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ extern "C" BOOL CRTInitStdStreams( void );

extern bool g_running_in_exe;

// #if defined(TARGET_ARM64)
// // Flag to check if atomics feature is available on
// // the machine
// bool g_arm64_atomics_present = false;
// #endif

Volatile<INT> init_count = 0;
Volatile<BOOL> shutdown_intent = 0;
Volatile<LONG> g_coreclrInitialized = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/utilcode/util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#ifndef DACCESS_COMPILE
UINT32 g_nClrInstanceId = 0;

#if defined(TARGET_WINDOWS) && defined(TARGET_ARM64)
#if defined(TARGET_ARM64)
// Flag to check if atomics feature is available on
// the machine
bool g_arm64_atomics_present = false;
Expand Down