Skip to content

Remove ThreadPool native implementation #71719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 22 commits into from
Aug 21, 2022
Merged

Remove ThreadPool native implementation #71719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d064de8
Remove UsePortableThreadPool() and UsePortableThreadPoolForIO()
Jul 6, 2022
be8de40
Delete more unnecessary functions
Jul 7, 2022
14e1757
Delete win32threadpool.cpp and win32threadpool.h
Jul 8, 2022
a5e1c9e
Add win32threadpool with other changes
Jul 8, 2022
a2b65d1
Add win32threadpool header back
Jul 8, 2022
aa50140
Current changes go until 381/577 during build native
Jul 8, 2022
568477e
Delete GetHillClimbingLogEntry in request.cpp, Delete hillclimbing st…
Jul 9, 2022
be9e5d4
Delete hillclimbing stuff in function GetThreadpoolData in request.cpp
Jul 9, 2022
8064d92
Delete GetHillClimbingLogEntry in dacimpl.h, sospriv.idl, sospriv.h
Jul 9, 2022
9cf256c
Delete DacpHillClimbingLogEntry in dacprivate.h
Jul 9, 2022
d24f554
Revert "Delete DacpHillClimbingLogEntry in dacprivate.h"
Jul 9, 2022
c3a8389
Revert "Delete GetHillClimbingLogEntry in dacimpl.h, sospriv.idl, sos…
Jul 9, 2022
566b4d7
Change GetThreadpoolData in request.cpp to return E_NOTIMPL
Jul 9, 2022
ed44b47
Keep SOSDacLeave(); in GetThreadpoolData in request.cpp
Jul 9, 2022
b6291d5
Merge branch 'main' into update/remove-threadpool-native-implementation
jkotas Jul 9, 2022
bdb28c7
Delete mode unused code
jkotas Jul 9, 2022
98fe65e
Delete TPIndex
jkotas Jul 9, 2022
43efcf4
Update src/coreclr/System.Private.CoreLib/src/System/Threading/Thread…
jkotas Jul 10, 2022
86aa5ac
Merge branch 'main' into update/remove-threadpool-native-implementation
jkotas Aug 20, 2022
afdd6c8
CR feedback
jkotas Aug 20, 2022
e0ba959
Fix crst ordering`
jkotas Aug 20, 2022
11da1f5
Cleanup
jkotas Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete GetHillClimbingLogEntry in dacimpl.h, sospriv.idl, sospriv.h
  • Loading branch information
Eduardo Manuel Velarde Polar committed Jul 9, 2022
commit 8064d92ca4379330a8ed49647ddf9692b2810366
1 change: 0 additions & 1 deletion src/coreclr/debug/daccess/dacimpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,6 @@ class ClrDataAccess
virtual HRESULT STDMETHODCALLTYPE GetHeapAnalyzeData(CLRDATA_ADDRESS addr,struct DacpGcHeapAnalyzeData *data);
virtual HRESULT STDMETHODCALLTYPE GetHeapAnalyzeStaticData(struct DacpGcHeapAnalyzeData *data);
virtual HRESULT STDMETHODCALLTYPE GetMethodDescTransparencyData(CLRDATA_ADDRESS methodDesc, struct DacpMethodDescTransparencyData *data);
virtual HRESULT STDMETHODCALLTYPE GetHillClimbingLogEntry(CLRDATA_ADDRESS addr, struct DacpHillClimbingLogEntry *data);
virtual HRESULT STDMETHODCALLTYPE GetThreadLocalModuleData(CLRDATA_ADDRESS thread, unsigned int index, struct DacpThreadLocalModuleData *data);
virtual HRESULT STDMETHODCALLTYPE GetRCWData(CLRDATA_ADDRESS addr, struct DacpRCWData *data);
virtual HRESULT STDMETHODCALLTYPE GetRCWInterfaces(CLRDATA_ADDRESS rcw, unsigned int count, struct DacpCOMInterfacePointerData interfaces[], unsigned int *pNeeded);
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/inc/sospriv.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ interface ISOSDacInterface : IUnknown
// ThreadPool
HRESULT GetThreadpoolData(struct DacpThreadpoolData *data);
HRESULT GetWorkRequestData(CLRDATA_ADDRESS addrWorkRequest, struct DacpWorkRequestData *data);
HRESULT GetHillClimbingLogEntry(CLRDATA_ADDRESS addr, struct DacpHillClimbingLogEntry *data);

// Objects
HRESULT GetObjectData(CLRDATA_ADDRESS objAddr, struct DacpObjectData *data);
Expand Down
12 changes: 0 additions & 12 deletions src/coreclr/pal/prebuilt/inc/sospriv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,10 +862,6 @@ EXTERN_C const IID IID_ISOSDacInterface;
CLRDATA_ADDRESS addrWorkRequest,
struct DacpWorkRequestData *data) = 0;

virtual HRESULT STDMETHODCALLTYPE GetHillClimbingLogEntry(
CLRDATA_ADDRESS addr,
struct DacpHillClimbingLogEntry *data) = 0;

virtual HRESULT STDMETHODCALLTYPE GetObjectData(
CLRDATA_ADDRESS objAddr,
struct DacpObjectData *data) = 0;
Expand Down Expand Up @@ -1321,11 +1317,6 @@ EXTERN_C const IID IID_ISOSDacInterface;
CLRDATA_ADDRESS addrWorkRequest,
struct DacpWorkRequestData *data);

HRESULT ( STDMETHODCALLTYPE *GetHillClimbingLogEntry )(
ISOSDacInterface * This,
CLRDATA_ADDRESS addr,
struct DacpHillClimbingLogEntry *data);

HRESULT ( STDMETHODCALLTYPE *GetObjectData )(
ISOSDacInterface * This,
CLRDATA_ADDRESS objAddr,
Expand Down Expand Up @@ -1760,9 +1751,6 @@ EXTERN_C const IID IID_ISOSDacInterface;
#define ISOSDacInterface_GetWorkRequestData(This,addrWorkRequest,data) \
( (This)->lpVtbl -> GetWorkRequestData(This,addrWorkRequest,data) )

#define ISOSDacInterface_GetHillClimbingLogEntry(This,addr,data) \
( (This)->lpVtbl -> GetHillClimbingLogEntry(This,addr,data) )

#define ISOSDacInterface_GetObjectData(This,objAddr,data) \
( (This)->lpVtbl -> GetObjectData(This,objAddr,data) )

Expand Down