Skip to content

Enabled System.ComponentModel.TypeConverter.Tests. #71821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 2 commits into from
Jul 9, 2022
Merged

Enabled System.ComponentModel.TypeConverter.Tests. #71821

radical merged 2 commits into from
Jul 9, 2022

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 8, 2022

Fixes #39709.
System.ComponentModel.TypeConverter.Tests on Browser are passing now.

@ilonatommy ilonatommy requested review from eerhardt, lewing and radical July 8, 2022 09:24
@ilonatommy ilonatommy self-assigned this Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #39709.
System.ComponentModel.TypeConverter.Tests on Browser are passing now.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.ComponentModel
Milestone: -

eerhardt
eerhardt approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@radical
Copy link
Member

radical commented Jul 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 8, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Jul 8, 2022

Running runtime-wasm so we can check the test for AOT also.

@radical
Copy link
Member

radical commented Jul 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 8, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical mentioned this pull request Jul 8, 2022
Closed
@radical
Copy link
Member

radical commented Jul 8, 2022

The wasm/HighResource_AOT failures are #71848 .

@radical radical merged commit 34fe496 into dotnet:main Jul 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@stephentoub stephentoub stephentoub approved these changes

@eerhardt eerhardt eerhardt approved these changes

@radical radical Awaiting requested review from radical

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-System.ComponentModel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] Enable System.Xml.Linq.Tests.XTypeDescriptionProviderTests class

5 participants

@ilonatommy @radical @lewing @stephentoub @eerhardt