Skip to content

Update wasm related README #71951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 1 commit into from
Jul 22, 2022
Merged

Update wasm related README #71951

pavelsavara merged 1 commit into from
Jul 22, 2022

Conversation

@yamachu
Copy link
Contributor

@yamachu yamachu commented Jul 11, 2022

ref: #70746

The above mentioned PR changed the default modules to es6.
I have applied its contents to README.

@yamachu yamachu requested a review from lewing as a code owner July 11, 2022 16:47
@ghost
Copy link

ghost commented Jul 11, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2022
@danmoseley danmoseley added arch-wasm WebAssembly architecture area-Meta labels Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

ref: #70746

The above mentioned PR changed the default modules to es6.
I have applied its contents to README.

Author: yamachu
Assignees: -
Labels:

arch-wasm, area-Meta, community-contribution
Milestone: -

@yamachu yamachu force-pushed the template-readme-esmodules branch from e248801 to c6a4c1b Compare July 21, 2022 18:17
@yamachu yamachu requested a review from pavelsavara as a code owner July 21, 2022 18:17
@yamachu
Copy link
Contributor Author

yamachu commented Jul 21, 2022

#72375
That PR changed the output of wasmconsole, do I need to update the README to show that?
If the way it is executed is correct, I don't see any problem with it.

> node main.mjs
could not load ./runArgs.json: Error: ENOENT: no such file or directory, stat './runArgs.json'. Ignoring
Debugger.Debug: DEBUGGING ENABLED

mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
Loaded 9239 symbols
Hello, World! Greetings from node version: v16.15.1
Hello, Console!

@pavelsavara
Copy link
Member

pavelsavara commented Jul 22, 2022

#72375 That PR changed the output of wasmconsole, do I need to update the README to show that? If the way it is executed is correct, I don't see any problem with it.

In my latest PR i'm changing how noisy some of those debug messages are. Let's update that bit later.

@pavelsavara pavelsavara merged commit e1764aa into dotnet:main Jul 22, 2022
@yamachu yamachu deleted the template-readme-esmodules branch July 25, 2022 10:09
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Meta community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yamachu @pavelsavara @danmoseley