[QUIC] Support for OpenSSL build of MsQuic on Windows (Attempt 2) #72609
Conversation
…uicApi.cs Co-authored-by: Marie Píchová <[email protected]>
…for-OpenSSL-build-of-MsQuic-on-Windows
…for-OpenSSL-build-of-MsQuic-on-Windows
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsCloses #69978. The problem with the original PR (#72262) was that in case that an incompatible MsQuic version was loaded, we didn't close the API Table handle before unloading the library. This led to us unloading the library while some code was still executing on a background MsQuic thread which crashed the process (this was way more probable on Release configurations than on Debug). This PR reintroduces the feature with appropriate changes.
|
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Looks good, thanks for looking into this!
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
Outdated
Show resolved
Hide resolved
| finally | ||
| { | ||
| if (!IsQuicSupported) | ||
| if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose)) |
There was a problem hiding this comment.
I guess we had the same issue before your change as well, we just never hit the right set of conditions for it to manifest and with your original change it happened on every Windows non-TLS1.3 machine.
There was a problem hiding this comment.
Yes, we did not hit it before because the OS version check was before we opened the MsQuic library. I had to move the OS check later once we knew which TLS backend MsQuic is using.
We could have still hit the issue when opening an older MsQuic version on sufficiently new Windows OS
…uicApi.cs Co-authored-by: Marie Píchová <[email protected]>
3 participants
Closes #69978.
The problem with the original PR (#72262) was that in case that an incompatible MsQuic version was loaded, we didn't close the API Table handle before unloading the library. This led to us unloading the library while some code was still executing on a background MsQuic thread which crashed the process (this was way more probable on Release configurations than on Debug). This PR reintroduces the feature with appropriate changes.