Fix HttpConnectionPool timers race on disposal #72615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der lock and check for disposed
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAccess _authorityExpireTimer and _altSvcBlocklistTimerCancellation under lock and check for disposed. Fixes #66782.
|
CarnaViire
commented
Jul 21, 2022
|
|
||
| Assert.Null(connectTimeoutException.InnerException); | ||
| Assert.DoesNotContain("42", e.ToString()); | ||
| Assert.DoesNotContain("HttpClient.Timeout", e.ToString()); |
Member
Author
There was a problem hiding this comment.
cc @MihaZupan it failed because some line number in the stacktrace contained 42 😄
antonfirsov
added a commit
to antonfirsov/runtime
that referenced
this pull request
Jul 21, 2022
MihaZupan
approved these changes
Jul 21, 2022
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access _authorityExpireTimer and _altSvcBlocklistTimerCancellation under lock and check for disposed.
Fixes #66782.