Skip to content

Port the doc changes to source #72638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 6 commits into from
Jul 22, 2022
Merged

Port the doc changes to source #72638

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6bf0f9e
Port the doc changes to source
tarekgh Jul 21, 2022
1edb343
Address the feedback
tarekgh Jul 21, 2022
561f684
Update src/libraries/System.ComponentModel.TypeConverter/src/System/C…
tarekgh Jul 21, 2022
bf7969d
Remove duplicated summary section
tarekgh Jul 21, 2022
b2b1c8f
reorder the doc elements
tarekgh Jul 21, 2022
e22932c
reorder the remaining doc elements
tarekgh Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorder the doc elements
  • Loading branch information
@tarekgh
tarekgh committed Jul 21, 2022
commit b2b1c8f8e552c9f9e4519e50b946df683cc0b42c
2 changes: 1 addition & 1 deletion ...raries/System.ComponentModel.TypeConverter/src/System/ComponentModel/DateOnlyConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ public override bool CanConvertTo(ITypeDescriptorContext? context, [NotNullWhen(
return base.ConvertFrom(context, culture, value);
}

/// <inheritdoc />
/// <summary>
/// Converts the given value object from a <see cref='System.DateOnly'/> object using the arguments.
/// </summary>
/// <inheritdoc />
public override object? ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)
{
if (destinationType == typeof(string) && value is DateOnly dateOnly)
Expand Down