Skip to content

Add GCDescs in front of MethodTable to dumps #72658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 2 commits into from
Jul 22, 2022
Merged

Add GCDescs in front of MethodTable to dumps #72658

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7aefe4
Add GCDescs in front of MethodTable to dumps
Jul 21, 2022
75b8f0d
Make DacValidateMethodTable more bullet proof by DAC'ifing the Method…
Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add GCDescs in front of MethodTable to dumps
  • Loading branch information
Mike McLaughlin committed Jul 22, 2022
commit a7aefe4e2a15a7910202af06438d51e8acd09e26
10 changes: 10 additions & 0 deletions src/coreclr/vm/methodtable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7835,6 +7835,16 @@ MethodTable::EnumMemoryRegions(CLRDataEnumMemoryFlags flags)
DWORD size = GetEndOffsetOfOptionalMembers();
DacEnumMemoryRegion(dac_cast<TADDR>(this), size);

// Make sure the GCDescs are added to the dump
if (ContainsPointers())
{
PTR_CGCDesc gcdesc = CGCDesc::GetCGCDescFromMT(this);
size_t size = gcdesc->GetSize();
// Manually calculate the start of the GCDescs because CGCDesc::GetStartOfGCData() isn't DAC'ified.
TADDR gcdescStart = dac_cast<TADDR>(this) - size;
DacEnumMemoryRegion(gcdescStart, size);
}

if (!IsCanonicalMethodTable())
{
PTR_MethodTable pMTCanonical = GetCanonicalMethodTable();
Expand Down