Skip to content

Include libnethost.pdb in implementation packages #72688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elinor-fung merged 1 commit into from
Jul 23, 2022
Merged

Include libnethost.pdb in implementation packages #72688

elinor-fung merged 1 commit into from
Jul 23, 2022

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jul 22, 2022 •
edited
Loading

Include libnethost.pdb in implementation packages for host runtime pack and nuget package - Microsoft.NETCore.App.Host.sfxproj and Microsoft.NETCore.DotNetAppHost.pkgproj - instead of just symbol packages.

Fixes #63602

cc @vitek-karas

@elinor-fung elinor-fung requested a review from a team July 22, 2022 17:31
@ghost ghost added the area-Setup label Jul 22, 2022
@ghost ghost assigned elinor-fung Jul 22, 2022
@elinor-fung elinor-fung merged commit 4735fd7 into dotnet:main Jul 23, 2022
@elinor-fung elinor-fung deleted the libnethostSymbols branch July 23, 2022 01:19
@EgorBo EgorBo mentioned this pull request Aug 17, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@elinor-fung elinor-fung

Labels

area-Setup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Symbols for libnethost.lib not shipped

2 participants

@elinor-fung @jkoritzinsky