Skip to content

Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer #72888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 6 commits into from
Jul 29, 2022
Merged

Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer #72888

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
251802e
Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer
jkoritzinsky Jul 26, 2022
260d122
Update resources to be consistent
jkoritzinsky Jul 28, 2022
78a1e81
Merge branch 'stateful-shape-analyzer' of github.com:jkoritzinsky/run…
jkoritzinsky Jul 28, 2022
ac3bb1c
Merge branch 'main' of github.com:dotnet/runtime into stateful-shape-…
jkoritzinsky Jul 28, 2022
4241d41
PR feedback and fix test build
jkoritzinsky Jul 28, 2022
5b5efac
Merge branch 'main' of github.com:dotnet/runtime into stateful-shape-…
jkoritzinsky Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' of github.com:dotnet/runtime into stateful-shape-… 
…analyzer
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Jul 29, 2022
commit 5b5efac71ef28db9a78e28f5d9643723d8c7b474
9 changes: 9 additions & 0 deletions ...ibraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,4 +488,13 @@
<data name="StatefulMarshallerRequiresFreeMessage" xml:space="preserve">
<value>The type '{0}' is a stateful marshaller and does not have a zero-parameter void-returning instance method named 'Free'</value>
</data>
<data name="ConvertToLibraryImportAddUnsafe" xml:space="preserve">
<value>Convert to 'LibraryImport' and enable unsafe code</value>
</data>
<data name="ConvertToLibraryImportMayRequireCustomMarshalling" xml:space="preserve">
<value>Converting this API to 'LibraryImport' will require additional code to provide custom marshallers for some parameters.</value>
</data>
<data name="ConvertToLibraryImportWithSuffixAddUnsafe" xml:space="preserve">
<value>Convert to 'LibraryImport' with '{0}' suffix and enable unsafe code</value>
</data>
</root>
You are viewing a condensed version of this merge commit. You can view the full changes here.