Skip to content

Add memory fences to ByRefAssignRef on Unix ARM64 #72919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 3 commits into from
Jul 28, 2022
Merged

Add memory fences to ByRefAssignRef on Unix ARM64 #72919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3c7731
Add ARM32 write barrier
MichalStrehovsky Jul 27, 2022
bc10578
Update WriteBarriers.S
MichalStrehovsky Jul 27, 2022
bb543a7
Update src/coreclr/nativeaot/Runtime/arm/WriteBarriers.S
MichalStrehovsky Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/coreclr/nativeaot/Runtime/arm/WriteBarriers.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ LEAF_END RhpCheckedXchg, _TEXT
// r2, r3: trashed
//
LEAF_ENTRY RhpByRefAssignRef, _TEXT
// See comment in RhpAssignRef
dmb

ldr r2, [r1]
str r2, [r0]

Expand Down
8 changes: 4 additions & 4 deletions src/coreclr/nativeaot/Runtime/arm64/WriteBarriers.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,13 @@ LEAF_END RhpCheckedAssignRefArm64, _TEXT
// x17 : trashed (ip1) if FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP
//
LEAF_ENTRY RhpByRefAssignRefArm64, _TEXT
ldr x15, [x13]
str x15, [x14]
ldr x15, [x13]
stlr x15, [x14]

INSERT_CHECKED_WRITE_BARRIER_CORE x14, x15, 12, X15

add X13, x13, #8
add x14, x14, #8
add X13, x13, #8
add x14, x14, #8

ret
LEAF_END RhpByRefAssignRefArm64, _TEXT