Skip to content

Disable NJulianRuleTest on Android #73030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 3 commits into from
Jul 29, 2022
Merged

Disable NJulianRuleTest on Android #73030

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c710be1
Diable NJulianRuleTest on Android
tarekgh Jul 28, 2022
e8c60b3
Add comment including the tracking issue
tarekgh Jul 28, 2022
e4989fa
Update src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
tarekgh Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs 
Co-authored-by: Ilona Tomkowicz <[email protected]>
  • Loading branch information
@tarekgh @ilonatommy
tarekgh and ilonatommy authored Jul 29, 2022
commit e4989fa2d908dec59625368acdb72528fc23a3e1
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2574,7 +2574,7 @@ public static void GetSystemTimeZones_AllTimeZonesHaveOffsetInValidRange()
};

// https://github.com/dotnet/runtime/issues/73031 is the tracking issue to investigate the test failure on Android.
private static bool CanRunNJulianRuleTest => PlatformDetection.IsNotAndroid && RemoteExecutor.IsSupported;
private static bool CanRunNJulianRuleTest => !PlatformDetection.IsLinuxBionic && RemoteExecutor.IsSupported;

[ConditionalTheory(nameof(CanRunNJulianRuleTest))]
[PlatformSpecific(TestPlatforms.AnyUnix)]
Expand Down