Skip to content

Add retry to symlink test #73042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 1 commit into from
Jul 30, 2022
Merged

Add retry to symlink test #73042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add retry to symlink test
  • Loading branch information
@danmoseley
danmoseley committed Jul 29, 2022
commit 111bd03fb18a2d4d51b90e4dc63554981179fbb2
6 changes: 5 additions & 1 deletion ...Microsoft.Extensions.FileProviders.Physical/tests/PhysicalFileProviderTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ public async Task UsePollingFileWatcher_UseActivePolling_HasChanged_SymbolicLink

// Act - Change link target to file 2.
File.Delete(linkPath);
File.CreateSymbolicLink(linkPath, file2Path);

RetryHelper.Execute(() =>
{
File.CreateSymbolicLink(linkPath, file2Path); // can fail, presumably due to some latency of delete of linkPath
}, maxAttempts: 10, retryWhen: e => e is UnauthorizedAccessException);

// Assert - It should report the change regardless of the timestamp being older.
Assert.True(await tcs.Task,
Expand Down