Skip to content

Add localloc empty stack verification #73109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 7 commits into from
Aug 1, 2022
Merged

Add localloc empty stack verification #73109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b07949
Add localloc empty stack verification
jl0pd Jul 30, 2022
53b9c5b
Fix build of tests
jl0pd Jul 30, 2022
41aad1f
Use Check instead of FatalCheck
jl0pd Jul 30, 2022
880ab85
Update error message
jl0pd Jul 30, 2022
f17dbf7
Add more tests
jl0pd Jul 30, 2022
804a720
Update src/coreclr/tools/ILVerification/Strings.resx
jkotas Jul 31, 2022
49ea7ff
Fix tests
jkotas Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Check instead of FatalCheck 
Co-authored-by: Jan Kotas <[email protected]>
  • Loading branch information
@jl0pd @jkotas
jl0pd and jkotas authored Jul 30, 2022
commit 41aad1fe37466ded6ca8da80098d20d1830566ae
2 changes: 1 addition & 1 deletion src/coreclr/tools/ILVerification/ILImporter.Verify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2582,7 +2582,7 @@ void ImportLocalAlloc()

var size = Pop();

FatalCheck(_stackTop == 0, VerifierError.LocallocStackNotEmpty);
Check(_stackTop == 0, VerifierError.LocallocStackNotEmpty);

CheckIsInteger(size);

Expand Down