-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Leverage the shipping, roslyn based ApiCompat in dotnet/runtime #73263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ViktorHofer
merged 53 commits into
dotnet:main
from
ViktorHofer:ConsumeApiCompatValidateAssembliesTask
Oct 16, 2022
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
4089ef2
ApiCompat infra changes
ViktorHofer 9ec4dde
Convert baseline to suppression files
ViktorHofer c49347d
ApiCompat.proj
ViktorHofer 9615fae
update suppressions
smasher164 49ce28d
sorted suppressions
smasher164 ce8871e
rebase and update suppressions
smasher164 610cc2a
enable attribute and param rules
smasher164 4d3cc27
Enable optional rules
ViktorHofer 60147fd
WebAssemblyThreading proj
ViktorHofer 5609581
CompatSuppression for XmlREaderWriter
ViktorHofer 6d0769c
Enable optional rules correctly...
ViktorHofer ed11fbe
ThreadPool UnsupportedOSPlatformAttribute
ViktorHofer eff5465
VBCore CP0017
ViktorHofer 2c55401
Migrate all CoreLibs over
ViktorHofer 81ea902
Update ApiCompat.proj
ViktorHofer 56b1070
Add ApiCompat.proj baselines
ViktorHofer a9d6da5
Update ApiCompat.proj
ViktorHofer 0b9da8f
Clean-up suppression files with nint/IntPtr fix
ViktorHofer 5ce44ea
Clean-up CoreLib suppression
ViktorHofer 68d6d56
Update suppression files with latest apicompat fix
ViktorHofer 54d37e1
Merge branch 'main' into ConsumeApiCompatValidateAssembliesTask
ViktorHofer c5236f4
Merge remote-tracking branch 'upstream/main' into ConsumeApiCompatVal…
ViktorHofer 779582d
Update suppression files
ViktorHofer 0630ec7
update suppressions
smasher164 5fb86eb
Update suppression files
ViktorHofer 5ecd6fe
Clean-up obsolete suppression files
ViktorHofer 4a1329d
Update suppression files
ViktorHofer c378e5c
Merge branch 'main' into ConsumeApiCompatValidateAssembliesTask
smasher164 a45f3d4
update suppressions
smasher164 b0e32ca
huge reduction in suppression file size
smasher164 857b383
update suppressions
smasher164 0998cbb
Merge branch 'main' of https://github.com/dotnet/runtime into Consume…
smasher164 b844b97
more suppressions removed
smasher164 2c34db6
update suppressions
smasher164 bd8c48f
Merge branch 'ConsumeApiCompatValidateAssembliesTask' of https://gith…
ViktorHofer 346a5a4
Merge remote-tracking branch 'upstream/main' into ConsumeApiCompatVal…
ViktorHofer eaf59fd
Update dependencies and clean-up
ViktorHofer b1ca777
Add suppression files for CoreLib and fix path
ViktorHofer 45b5aa5
Update CoreLib coreclr suppression file
ViktorHofer ea745fe
Update coreclr suppression files
ViktorHofer 1054c68
Suppression file fixes and Linux path fixes
ViktorHofer 08c7c89
Update coreclr suppression again)
ViktorHofer 875b0ce
Fix suppression file path calculation
ViktorHofer 6126424
Fix previous mistake
ViktorHofer 504092f
Diagnostics.Tracing suppression file
ViktorHofer 107080b
Threading suppression file fix
ViktorHofer 48d56fa
Merge remote-tracking branch 'upstream/main' into ConsumeApiCompatVal…
ViktorHofer a3334bd
use global suppression for CryptoSignedXmlRecursionException
smasher164 ff41f8a
Merge remote-tracking branch 'upstream/main' into ConsumeApiCompatVal…
ViktorHofer 5db9a5e
Add Specification.Tests suppression
ViktorHofer 2af0165
Disable NoTargets ref copying
ViktorHofer ddf1391
Fix for coreclr build
ViktorHofer c346c88
Avoid duplicate project evals
ViktorHofer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update suppression files with latest apicompat fix
- Loading branch information
commit 68d6d56457906c703b34f21a454bb95239dc6166
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/libraries/System.Configuration.ConfigurationManager/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.Internal.DelegatingConfigHost.get_HasLocalConfig</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.Internal.DelegatingConfigHost.get_HasRoamingConfig</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.Internal.DelegatingConfigHost.get_IsAppConfigHttp</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.Internal.DelegatingConfigHost.RefreshConfigPaths</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.SettingsAttributeDictionary.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:System.Configuration.SettingsContext.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)</Target> | ||
| <Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left> | ||
| <Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right> | ||
| </Suppression> | ||
| </Suppressions> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
src/libraries/System.IO.Compression/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- Exposed publicly only in implementation for serialization compat. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Compression.ZLibException</Target> | ||
| <Left>ref/net7.0/System.IO.Compression.dll</Left> | ||
| <Right>runtimes/browser/lib/net7.0/System.IO.Compression.dll</Right> | ||
| </Suppression> | ||
| </Suppressions> |
15 changes: 1 addition & 14 deletions
15
src/libraries/System.IO.Pipes/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,32 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- Exposed public in System.IO.Pipes.AccessControl but implemented in System.IO.Pipes. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.AnonymousPipeServerStreamAcl</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.NamedPipeServerStreamAcl</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.PipeAccessRights</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.PipeAccessRule</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.PipeAuditRule</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.PipesAclExtensions</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.IO.Pipes.PipeSecurity</Target> | ||
| <Left>ref/net7.0/System.IO.Pipes.dll</Left> | ||
| <Right>runtimes/unix/lib/net7.0/System.IO.Pipes.dll</Right> | ||
| </Suppression> | ||
| </Suppressions> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.