Skip to content

Port IndexOfAny(ref char, char[1-5], int) to Vector128/256 #73469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 9 commits into from
Aug 13, 2022
Merged

Port IndexOfAny(ref char, char[1-5], int) to Vector128/256 #73469

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
697e3b6
port SpanHelpers.IndexOfAny(ref char, char, char, int) to Vector128/256
adamsitnik Aug 5, 2022
33e9022
port SpanHelpers.IndexOfAny(ref char, char, char, char, int)
adamsitnik Aug 5, 2022
3191968
SpanHelpers.IndexOfAny(ref char, char, char, char, char, int)
adamsitnik Aug 5, 2022
43e6a5e
SpanHelpers.IndexOfAny(ref char, char, char, char, char, char, int)
adamsitnik Aug 5, 2022
91581df
polishing
adamsitnik Aug 5, 2022
5c67de1
perform more than 3 Or at once, observe a nice perf boost
adamsitnik Aug 5, 2022
fba7d16
perform more than 3 Or at once, observe perf boost on ARM64
adamsitnik Aug 5, 2022
7bd44b5
Merge branch 'dotnet:main' into indexOfAnyChar
adamsitnik Aug 10, 2022
9cf1956
Merge remote-tracking branch 'upstream/main' into indexOfAnyChar
adamsitnik Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perform more than 3 Or at once, observe perf boost on ARM64
  • Loading branch information
@adamsitnik
adamsitnik committed Aug 5, 2022
commit fba7d16a74202d2ed3518da47f5ac95a3a7b2bc1
17 changes: 9 additions & 8 deletions src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Char.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,8 +1373,8 @@ public static unsafe int IndexOfAny(ref char searchStart, char value0, char valu
{
search = Vector128.LoadUnsafe(ref ushortSearchStart, offset);

compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search);
compareResult |= Vector128.Equals(values2, search) | Vector128.Equals(values3, search);
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search)
| Vector128.Equals(values2, search) | Vector128.Equals(values3, search);
if (compareResult == Vector128<ushort>.Zero)
{
// None matched
Expand All @@ -1391,8 +1391,8 @@ public static unsafe int IndexOfAny(ref char searchStart, char value0, char valu
search = Vector128.LoadUnsafe(ref ushortSearchStart, lengthToExamine);
offset = lengthToExamine;
// Same as method as above
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search);
compareResult |= Vector128.Equals(values2, search) | Vector128.Equals(values3, search);
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search)
| Vector128.Equals(values2, search) | Vector128.Equals(values3, search);
if (compareResult == Vector128<ushort>.Zero)
{
// None matched
Expand Down Expand Up @@ -1593,6 +1593,7 @@ public static unsafe int IndexOfAny(ref char searchStart, char value0, char valu
// Same as method as above
matches = (Vector256.Equals(values0, search) | Vector256.Equals(values1, search) | Vector256.Equals(values2, search)
| Vector256.Equals(values3, search) | Vector256.Equals(values4, search))
.AsByte().ExtractMostSignificantBits();
if (matches == 0)
{
// None matched
Expand All @@ -1617,8 +1618,8 @@ public static unsafe int IndexOfAny(ref char searchStart, char value0, char valu
{
search = Vector128.LoadUnsafe(ref ushortSearchStart, offset);

compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search) | Vector128.Equals(values2, search);
compareResult |= Vector128.Equals(values3, search) | Vector128.Equals(values4, search);
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search) | Vector128.Equals(values2, search)
| Vector128.Equals(values3, search) | Vector128.Equals(values4, search);
if (compareResult == Vector128<ushort>.Zero)
{
// None matched
Expand All @@ -1635,8 +1636,8 @@ public static unsafe int IndexOfAny(ref char searchStart, char value0, char valu
search = Vector128.LoadUnsafe(ref ushortSearchStart, lengthToExamine);
offset = lengthToExamine;
// Same as method as above
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search) | Vector128.Equals(values2, search);
compareResult |= Vector128.Equals(values3, search) | Vector128.Equals(values4, search);
compareResult = Vector128.Equals(values0, search) | Vector128.Equals(values1, search) | Vector128.Equals(values2, search)
| Vector128.Equals(values3, search) | Vector128.Equals(values4, search);
if (compareResult == Vector128<ushort>.Zero)
{
// None matched
Expand Down