Skip to content

[HTTP3] Correctly handle server closing a control stream #73680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 3 commits into from
Aug 11, 2022
+171 −53
Merged

[HTTP3] Correctly handle server closing a control stream #73680

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0edb95
Handle HTTP3 server closing its controls stream
rzikm Aug 10, 2022
1581732
React to server closing inbound control stream
rzikm Aug 10, 2022
3a4bdff
Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpH…
rzikm Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpH… 
…andler/Http3Connection.cs

Co-authored-by: Marie Píchová <[email protected]>
  • Loading branch information
@rzikm @ManickaP
rzikm and ManickaP authored Aug 10, 2022
commit 3a4bdffbe4478b8ac927ee33d753a8f7dd146c1e
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ private async Task SendSettingsAsync()
// Server MUST NOT abort our control stream, setup a continuation which will react accordingly
_ = _clientControl.WritesClosed.ContinueWith(t =>
{
if (t.Exception?.InnerExceptions.FirstOrDefault() is QuicException ex && ex.QuicError == QuicError.StreamAborted)
if (t.Exception?.InnerException is QuicException ex && ex.QuicError == QuicError.StreamAborted)
{
Abort(HttpProtocolException.CreateHttp3ConnectionException(Http3ErrorCode.ClosedCriticalStream));
}
Expand Down