Skip to content

[libs] Remove JitInfoIsPopulated mobile activeissue #73716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdh1418 merged 1 commit into from
Aug 11, 2022
Merged

[libs] Remove JitInfoIsPopulated mobile activeissue #73716

mdh1418 merged 1 commit into from
Aug 11, 2022

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 10, 2022 •
edited
Loading

Fixes #55712

@ghost
Copy link

ghost commented Aug 10, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned mdh1418 Aug 10, 2022
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 10, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mdh1418
Assignees: mdh1418
Labels:

area-System.Runtime
Milestone: -

@danmoseley danmoseley added os-ios Apple iOS os-tvos Apple tvOS os-android labels Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mdh1418
Assignees: mdh1418
Labels:

area-System.Runtime, os-android, os-ios, os-tvos
Milestone: -

@mdh1418 mdh1418 mentioned this pull request Aug 11, 2022
Closed
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 11, 2022

From the CI tests, it looks like iOS and tvOS now skip the test because IsReflectionEmitSupported is not met, and it passes on MacCatalyst.

The failure on runtime is the same suite but a different test, and this PR removes an ActiveIssue for non-Windows platforms. It should be unrelated, but logged #73739

@mdh1418 mdh1418 merged commit deac993 into dotnet:main Aug 11, 2022
@mdh1418 mdh1418 deleted the remove_jitinfoispopulated_activeissue branch August 11, 2022 14:50
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@mdh1418 mdh1418

Labels

area-System.Runtime os-android os-ios Apple iOS os-tvos Apple tvOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JitInfoIsPopulated failed with after is not greater than before

3 participants

@mdh1418 @akoeplinger @danmoseley