Skip to content

Remove unnecessary runtime lookup for constrained callvirt #73823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trylek merged 1 commit into from
Aug 24, 2022
Merged

Remove unnecessary runtime lookup for constrained callvirt #73823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unnecessary runtime lookup for constrained callvirt 
In my change adding support for default static virtual interface
method implementations I made a subtle bug that caused
behavioral change for some pre-existing constrained virtual calls
that newly started to require runtime lookup. This is unnecessary
and perf-negative, I have modified the code so that my change
kicks in only for static virtual methods.

Thanks

Tomas
  • Loading branch information
@trylek
trylek committed Aug 23, 2022
commit ad2966134c941bb9be57ba7344177a02121d3b67
2 changes: 1 addition & 1 deletion src/coreclr/vm/jitinterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4882,7 +4882,7 @@ void CEEInfo::getCallInfo(
MethodDesc * pTargetMD = pMDAfterConstraintResolution;
DWORD dwTargetMethodAttrs = pTargetMD->GetAttrs();

pResult->exactContextNeedsRuntimeLookup = (!constrainedType.IsNull() && constrainedType.IsCanonicalSubtype());
pResult->exactContextNeedsRuntimeLookup = (fIsStaticVirtualMethod && !fResolvedConstraint && !constrainedType.IsNull() && constrainedType.IsCanonicalSubtype());

if (pTargetMD->HasMethodInstantiation())
{
Expand Down