Skip to content

Ignore LoopbackServer exceptions in MaxHeadersLength test #73937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MihaZupan wants to merge 6 commits into from
Closed

Ignore LoopbackServer exceptions in MaxHeadersLength test #73937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
333048e
Ignore LoopbackServer exceptions in MaxHeadersLength test
MihaZupan Aug 15, 2022
4426774
Http3 test
MihaZupan Aug 15, 2022
34817ae
Move test to SocketsHttpHandlerTest file
MihaZupan Aug 15, 2022
1be7244
Repeat test to increase odds of failing
MihaZupan Aug 17, 2022
8f488fc
Repeat all the things
MihaZupan Aug 18, 2022
ab7ff63
Add some rng
MihaZupan Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move test to SocketsHttpHandlerTest file
  • Loading branch information
@MihaZupan
MihaZupan committed Aug 15, 2022
commit 34817aecbf5ea54507b306bd6497897cccfd8ab8
44 changes: 0 additions & 44 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,50 +22,6 @@ public abstract class HttpClientHandler_MaxResponseHeadersLength_Test : HttpClie
{
public HttpClientHandler_MaxResponseHeadersLength_Test(ITestOutputHelper output) : base(output) { }

[Theory]
[InlineData(null)]
[InlineData(1)]
[InlineData(16)]
[InlineData(64)]
[InlineData(256)]
[InlineData(1024)]
[InlineData(10240)]
public async Task Http3Test(int? maxResponseHeadersLength)
{
if (UseVersion.Major != 3) return;

var requestCts = new CancellationTokenSource();
var controlStreamEstablishedTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
using HttpClientHandler handler = CreateHttpClientHandler();
using HttpClient client = CreateHttpClient(handler);

if (maxResponseHeadersLength.HasValue)
{
handler.MaxResponseHeadersLength = maxResponseHeadersLength.Value;
}

await Assert.ThrowsAnyAsync<Exception>(() => client.GetAsync(uri, requestCts.Token));

await controlStreamEstablishedTcs.Task.WaitAsync(TestHelper.PassingTestTimeout);
},
async server =>
{
await server.AcceptConnectionAsync(async connection =>
{
requestCts.Cancel();

var http3Connection = (Http3LoopbackConnection)connection;

await http3Connection.EnsureControlStreamAcceptedAsync().WaitAsync(TestHelper.PassingTestTimeout);

controlStreamEstablishedTcs.SetResult();
});
});
}

[Theory]
[InlineData(0)]
[InlineData(-1)]
Expand Down
42 changes: 42 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,6 +1245,48 @@ public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLengt
{
public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3(ITestOutputHelper output) : base(output) { }
protected override Version UseVersion => HttpVersion.Version30;

[Theory]
[InlineData(null)]
[InlineData(1)]
[InlineData(16)]
[InlineData(64)]
[InlineData(256)]
[InlineData(1024)]
[InlineData(10240)]
public async Task Http3Test(int? maxResponseHeadersLength)
{
var requestCts = new CancellationTokenSource();
var controlStreamEstablishedTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
using HttpClientHandler handler = CreateHttpClientHandler();
using HttpClient client = CreateHttpClient(handler);

if (maxResponseHeadersLength.HasValue)
{
handler.MaxResponseHeadersLength = maxResponseHeadersLength.Value;
}

await Assert.ThrowsAnyAsync<Exception>(() => client.GetAsync(uri, requestCts.Token));

await controlStreamEstablishedTcs.Task.WaitAsync(TestHelper.PassingTestTimeout);
},
async server =>
{
await server.AcceptConnectionAsync(async connection =>
{
requestCts.Cancel();

var http3Connection = (Http3LoopbackConnection)connection;

await http3Connection.EnsureControlStreamAcceptedAsync().WaitAsync(TestHelper.PassingTestTimeout);

controlStreamEstablishedTcs.SetResult();
});
});
}
}

[SkipOnPlatform(TestPlatforms.Browser, "Socket is not supported on Browser")]
Expand Down