Skip to content

Directory.CreateDirectory: create missing parents using default UnixFileMode. #74002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jozkee merged 7 commits into from
Aug 19, 2022
Merged

Directory.CreateDirectory: create missing parents using default UnixFileMode. #74002

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0acc3c
Directory.CreateDirectory: create missing parents using default UnixF…
tmds Aug 16, 2022
253e68a
Simplify TarHelpers.CreateDirectory.
tmds Aug 17, 2022
daed79e
PR feedback.
tmds Aug 18, 2022
03858aa
AssertFileModeEquals: don't skip on Android.
tmds Aug 19, 2022
7f3d1bd
Always overwite directory metadata.
tmds Aug 19, 2022
5271907
TarHelpers.Windows: remove CreateDirectory overwriteMetadata.
tmds Aug 19, 2022
e1cf9d4
Fix Assert indentation.
tmds Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix Assert indentation.
  • Loading branch information
@tmds
tmds committed Aug 19, 2022
commit e1cf9d43604d94c782f0d8712417427879c6f9b6
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public async Task UnixFileModes_Async(bool overwrite)

await TarFile.ExtractToDirectoryAsync(archivePath, destination.Path, overwriteFiles: overwrite);

Assert.True(Directory.Exists(dirPath), $"{dirPath}' does not exist.");
Assert.True(Directory.Exists(dirPath), $"{dirPath}' does not exist.");
AssertFileModeEquals(dirPath, TestPermission1);

Assert.True(File.Exists(filePath), $"{filePath}' does not exist.");
Expand Down