Update S.R.Metadata in HostModel #74009
Conversation
ghost
added
area-HostModel
|
Tagging subscribers to this area: @vitek-karas, @agocke Issue Details
|
| <!-- Installer dependencies --> | ||
| <MicrosoftNETCoreAppRuntimewinx64Version>7.0.0-rc.1.22414.6</MicrosoftNETCoreAppRuntimewinx64Version> | ||
| <MicrosoftNETCoreDotNetHostVersion>7.0.0-rc.1.22414.6</MicrosoftNETCoreDotNetHostVersion> | ||
| <MicrosoftNETCoreDotNetHostPolicyVersion>7.0.0-rc.1.22414.6</MicrosoftNETCoreDotNetHostPolicyVersion> |
Some tests are failing due to the indirect dependencies on S.C.I.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.Reflection.Metadata" Version="1.8.0" /> | ||
| <PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" /> |
There was a problem hiding this comment.
We need to ensure that we're matching the version of System.Reflection.Metadata that is in the SDK, as version mismatches can cause significant issues when running on the Full Framework version of MSBuild.
There was a problem hiding this comment.
Looks like we can update to 6.0.0 (the current value of SystemReflectionMetadataVersion) as it's the same as the sdk's version.
There was a problem hiding this comment.
Yup, I first tested updating SystemReflectionMetadataVersion to 7.0 preview7, but ILCompiler.Build.Tasks.csproj requirement is that we keep SystemCollectionsImmutableVersion and SystemReflectionMetadataVersion in sync. Updating System.Collections.Immutable to 7.0 preview7 was failing Pri0 tests (XUnitWrapperGenerator was unable to load S.C.I among other things), so I reverted that change.
This reverts commit 7e4b3c1.
ghost
locked as resolved and limited conversation to collaborators
2 participants
Use shared version of
System.Reflection.Metadatain HostModel. It is compatible with netstandard2.0.