Skip to content

Add intrinsic for IndexOfAny on Arm64 #74010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SwapnilGaikwad wants to merge 2 commits into from
Closed

Add intrinsic for IndexOfAny on Arm64 #74010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5898e80
Add intrinsic for IndexOfAny on AArch64
SwapnilGaikwad Aug 8, 2022
3839537
Merge branch 'main' into github-indexOfAny-char-arm64
SwapnilGaikwad Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add intrinsic for IndexOfAny on AArch64
  • Loading branch information
@SwapnilGaikwad
SwapnilGaikwad committed Aug 25, 2022
commit 5898e80f3bcfd311d128dfe96495fbb659a174b2
55 changes: 43 additions & 12 deletions src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Numerics;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using System.Runtime.Intrinsics.Arm;

namespace System
{
Expand Down Expand Up @@ -1543,7 +1544,7 @@ private static int IndexOfValueType<TValue, TNegator>(ref TValue searchSpace, TV
do
{
equals = TNegator.NegateIfNeeded(Vector128.Equals(values, Vector128.LoadUnsafe(ref currentSearchSpace)));
if (equals == Vector128<TValue>.Zero)
if (!VectorContainsMatch(equals))
{
currentSearchSpace = ref Unsafe.Add(ref currentSearchSpace, Vector128<TValue>.Count);
continue;
Expand All @@ -1557,7 +1558,7 @@ private static int IndexOfValueType<TValue, TNegator>(ref TValue searchSpace, TV
if ((uint)length % Vector128<TValue>.Count != 0)
{
equals = TNegator.NegateIfNeeded(Vector128.Equals(values, Vector128.LoadUnsafe(ref oneVectorAwayFromEnd)));
if (equals != Vector128<TValue>.Zero)
if (VectorContainsMatch(equals))
{
return ComputeFirstIndex(ref searchSpace, ref oneVectorAwayFromEnd, equals);
}
Expand Down Expand Up @@ -1691,7 +1692,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
{
current = Vector128.LoadUnsafe(ref currentSearchSpace);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current));
if (equals == Vector128<TValue>.Zero)
if (!VectorContainsMatch(equals))
{
currentSearchSpace = ref Unsafe.Add(ref currentSearchSpace, Vector128<TValue>.Count);
continue;
Expand All @@ -1706,7 +1707,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
{
current = Vector128.LoadUnsafe(ref oneVectorAwayFromEnd);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current));
if (equals != Vector128<TValue>.Zero)
if (VectorContainsMatch(equals))
{
return ComputeFirstIndex(ref searchSpace, ref oneVectorAwayFromEnd, equals);
}
Expand Down Expand Up @@ -1835,7 +1836,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
{
current = Vector128.LoadUnsafe(ref currentSearchSpace);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current) | Vector128.Equals(values2, current));
if (equals == Vector128<TValue>.Zero)
if (!VectorContainsMatch(equals))
{
currentSearchSpace = ref Unsafe.Add(ref currentSearchSpace, Vector128<TValue>.Count);
continue;
Expand All @@ -1850,7 +1851,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
{
current = Vector128.LoadUnsafe(ref oneVectorAwayFromEnd);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current) | Vector128.Equals(values2, current));
if (equals != Vector128<TValue>.Zero)
if (VectorContainsMatch(equals))
{
return ComputeFirstIndex(ref searchSpace, ref oneVectorAwayFromEnd, equals);
}
Expand Down Expand Up @@ -1954,7 +1955,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
current = Vector128.LoadUnsafe(ref currentSearchSpace);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current)
| Vector128.Equals(values2, current) | Vector128.Equals(values3, current));
if (equals == Vector128<TValue>.Zero)
if (!VectorContainsMatch(equals))
{
currentSearchSpace = ref Unsafe.Add(ref currentSearchSpace, Vector128<TValue>.Count);
continue;
Expand All @@ -1970,7 +1971,7 @@ private static int IndexOfAnyValueType<TValue, TNegator>(ref TValue searchSpace,
current = Vector128.LoadUnsafe(ref oneVectorAwayFromEnd);
equals = TNegator.NegateIfNeeded(Vector128.Equals(values0, current) | Vector128.Equals(values1, current)
| Vector128.Equals(values2, current) | Vector128.Equals(values3, current));
if (equals != Vector128<TValue>.Zero)
if (VectorContainsMatch(equals))
{
return ComputeFirstIndex(ref searchSpace, ref oneVectorAwayFromEnd, equals);
}
Expand Down Expand Up @@ -2067,7 +2068,7 @@ internal static int IndexOfAnyValueType<T>(ref T searchSpace, T value0, T value1
current = Vector128.LoadUnsafe(ref currentSearchSpace);
equals = Vector128.Equals(values0, current) | Vector128.Equals(values1, current) | Vector128.Equals(values2, current)
| Vector128.Equals(values3, current) | Vector128.Equals(values4, current);
if (equals == Vector128<T>.Zero)
if (!VectorContainsMatch(equals))
{
currentSearchSpace = ref Unsafe.Add(ref currentSearchSpace, Vector128<T>.Count);
continue;
Expand All @@ -2083,7 +2084,7 @@ internal static int IndexOfAnyValueType<T>(ref T searchSpace, T value0, T value1
current = Vector128.LoadUnsafe(ref oneVectorAwayFromEnd);
equals = Vector128.Equals(values0, current) | Vector128.Equals(values1, current) | Vector128.Equals(values2, current)
| Vector128.Equals(values3, current) | Vector128.Equals(values4, current);
if (equals != Vector128<T>.Zero)
if (VectorContainsMatch(equals))
{
return ComputeFirstIndex(ref searchSpace, ref oneVectorAwayFromEnd, equals);
}
Expand Down Expand Up @@ -2614,11 +2615,41 @@ private static int LastIndexOfAnyValueType<TValue, TNegator>(ref TValue searchSp
return -1;
}

[MethodImpl(MethodImplOptions.AggressiveOptimization)]
private static bool VectorContainsMatch<TValue>(Vector128<TValue> inputVector) where TValue : struct, INumber<TValue>
{
// The inputVector has all the bits of a matching element set.
if (AdvSimd.Arm64.IsSupported)
{
// We select a larger byte from the adjacent pair of bytes. Thus, if any of the 16 bytes of inputVector are set,
// representing a matched element, they get reflected in the bottom half (8 bytes) of the register.
// We then detect a match when any of the bottom 8 bytes are non-zero.
return AdvSimd.Arm64.MaxPairwise(inputVector.AsByte(), inputVector.AsByte()).AsUInt64().ToScalar() != 0;
}
else
{
return (inputVector != Vector128<TValue>.Zero);
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static int ComputeFirstIndex<T>(ref T searchSpace, ref T current, Vector128<T> equals) where T : struct
{
uint notEqualsElements = equals.ExtractMostSignificantBits();
int index = BitOperations.TrailingZeroCount(notEqualsElements);
int index;
if (AdvSimd.Arm64.IsSupported && Unsafe.SizeOf<T>() > 1)
{
// PairwiseMax selects a larger of the adjacent elements. Now the bottom half of
// the target register (64 bits) represents elements of half the original size.
// Dividing the number of trailing zeros by 4 gives the byte offset position of
// the first matching element, and dividing it by the element size gives its index.
index = (BitOperations.TrailingZeroCount(
AdvSimd.Arm64.MaxPairwise(equals.AsByte(), equals.AsByte()).AsUInt64().ToScalar()) >> 2) / Unsafe.SizeOf<T>();
}
else
{
uint notEqualsElements = equals.ExtractMostSignificantBits();
index = BitOperations.TrailingZeroCount(notEqualsElements);
}
return index + (int)(Unsafe.ByteOffset(ref searchSpace, ref current) / Unsafe.SizeOf<T>());
}

Expand Down