Skip to content

[release/7.0-rc1] [wasm][debugger] Hide members from classes that don't have debug information #74029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 5 commits into from
Aug 17, 2022
Merged

[release/7.0-rc1] [wasm][debugger] Hide members from classes that don't have debug information #74029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc2dffc
adding fields that are from non-user-code as private
thaystg Aug 15, 2022
af9c1ec
Do not show members from types that doesn't have debug information if…
thaystg Aug 16, 2022
56388e5
Addressing @radical comments.
thaystg Aug 16, 2022
9bcfca3
Apply suggestions from code review
thaystg Aug 16, 2022
d70f222
Adding more tests.
thaystg Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Ankit Jain <[email protected]>
  • Loading branch information
@thaystg @radical
2 people authored and github-actions committed Aug 16, 2022
commit 9bcfca32d7203f1607fad5e7b1f3ad0eef87bfd6
6 changes: 3 additions & 3 deletions src/mono/wasm/debugger/tests/debugger-test-without-debug-symbols-to-load/test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ public class ClassWithoutDebugSymbolsToInherit
private int d;
public int e;
protected int f;
public int G
{
get {return f + 1;}
public int G
{
get {return f + 1;}
}
public int H => f;

Expand Down
6 changes: 3 additions & 3 deletions src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,9 +1300,9 @@ public class ClassNonUserCodeToInherit
private int d;
public int e;
protected int f;
public int G
{
get {return f + 1;}
public int G
{
get {return f + 1;}
}
public int H => f;

Expand Down