Skip to content

[release/7.0-rc1] Optimized string.Replace(char, char) #74047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 11 commits into from
Aug 17, 2022
Merged

[release/7.0-rc1] Optimized string.Replace(char, char) #74047

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
090f739
Optimized string.Replace(char, char) vector code path
gfoidl Mar 22, 2022
d366d93
Optimized code pathes even further
gfoidl Mar 23, 2022
b4dcd15
Do vectorized operation at the end of the string only once
gfoidl Apr 13, 2022
424f16b
Don't use trick for collapsed epilogs
gfoidl Jul 20, 2022
98c3f6a
Handle remainder vectorized even if remainingLength <= Vector<ushort>…
gfoidl Jul 20, 2022
0a395c0
Introduce (internal) Vector.LoadUnsafe and Vector.StoreUnsafe and use…
gfoidl Jul 20, 2022
c5f4740
Avoid Unsafe.As<char, ushort> reinterpret casts by introducing string…
gfoidl Jul 20, 2022
5686225
Fixed copy/paste error (from local dev to repo)
gfoidl Jul 20, 2022
d875e1f
PR Feedback
gfoidl Aug 15, 2022
d011202
Fixed bug and added tests for this
gfoidl Aug 15, 2022
7b8adce
Make condition about lengthToExamine clearer as suggested
gfoidl Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use trick for collapsed epilogs 
Cf. #67049 (comment)
  • Loading branch information
@gfoidl
gfoidl authored and github-actions committed Aug 17, 2022
commit 424f16bdb3fc3ce0e49adb25ee6b3dfe45883c33
10 changes: 6 additions & 4 deletions src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,11 +986,13 @@ private string ReplaceCore(string oldValue, string? newValue, CompareInfo? ci, C
//
public string Replace(char oldChar, char newChar)
{
int firstIndex;
if (oldChar == newChar || (firstIndex = IndexOf(oldChar)) < 0)
{
if (oldChar == newChar)
return this;

int firstIndex = IndexOf(oldChar);

if (firstIndex < 0)
return this;
}

int remainingLength = Length - firstIndex;
string result = FastAllocateString(Length);
Expand Down