Skip to content

[release/7.0-rc1] Fix nullable annotations on generic math interfaces #74116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Aug 18, 2022
Merged

[release/7.0-rc1] Fix nullable annotations on generic math interfaces #74116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8039e70
Fix nullable annotations on generic math interfaces
stephentoub Aug 16, 2022
cfe408e
Address PR feedback
stephentoub Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address PR feedback
  • Loading branch information
@stephentoub
stephentoub authored and github-actions committed Aug 18, 2022
commit cfe408e050356047319d7520791633c13c1db496
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Half.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,7 +1741,7 @@ static bool INumberBase<Half>.TryConvertToChecked<TOther>(Half value, [MaybeNull
if (typeof(TOther) == typeof(byte))
{
byte actualResult = checked((byte)value);
result = (TOther)(object)actualResult!;
result = (TOther)(object)actualResult;
return true;
}
else if (typeof(TOther) == typeof(char))
Expand Down