Skip to content

Disable Int128 use in by value ABI scenarios, and fix field layout behavior #74123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwrighton merged 12 commits into from
Aug 19, 2022
Merged

Disable Int128 use in by value ABI scenarios, and fix field layout behavior #74123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
29ea888
First stab at support for proper 128bit integer layout and abi
davidwrighton Aug 17, 2022
ca40e03
Add ABI tests for Int128 covering interesting scenarios
davidwrighton Aug 9, 2022
183a36e
Fix bugs so that at least Windows Arm64 works
davidwrighton Aug 17, 2022
823090b
Add more types to the ABI tester, so that we cover the Int128 scenarios
davidwrighton Aug 18, 2022
22adce8
Revert changes which attempted to enable by value passing for Int128
davidwrighton Aug 18, 2022
e36292f
Make Int128 have layout match the expected unmanaged field layout
davidwrighton Aug 18, 2022
867ab2e
Mark Int128 types as not having a stable abi
davidwrighton Aug 18, 2022
8585002
Address all known issues
davidwrighton Aug 19, 2022
fdba562
Merge branch 'main' of github.com:dotnet/runtime into fix_72206_2
davidwrighton Aug 19, 2022
4fab4d3
Try to fix PR job
davidwrighton Aug 19, 2022
1170afe
Should fix the test issues
davidwrighton Aug 19, 2022
81c4439
Apply suggestions from code review
davidwrighton Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Should fix the test issues
  • Loading branch information
@davidwrighton
davidwrighton committed Aug 19, 2022
commit 1170afe4a396cfe72cc91850715ab652861e2d31
2 changes: 1 addition & 1 deletion src/tests/JIT/Stress/ABI/Gen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ internal static object GenConstant(Type type, FieldInfo[] fields, Random rand)
return (double)rand.Next();

if (type == typeof(Int128))
return new Int128((ulong)GenConstant(typeof(ulong), null, rand), (ulong)GenConstant(typeof(ulong), null, rand));
return new Int128((ulong)(long)GenConstant(typeof(long), null, rand), (ulong)(long)GenConstant(typeof(long), null, rand));

if (type == typeof(Vector<int>))
return GenConstantVector<Vector<int>, int>(rand);
Expand Down
6 changes: 3 additions & 3 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@

<!-- All OS/Arch CoreCLR excludes -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(RuntimeFlavor)' == 'coreclr' ">
<ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/StackTracePreserve/StackTracePreserveTests/*">
<Issue>https://github.com/dotnet/runtime/issues/11213</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/StackTracePreserve/StackTracePreserveTests/*">
<Issue>https://github.com/dotnet/runtime/issues/11213</Issue>
</ExcludeList>
Expand Down Expand Up @@ -1424,6 +1421,9 @@

<!-- Known failures for mono runtime on *all* architectures/operating systems in *all* runtime modes -->
<ItemGroup Condition="'$(RuntimeFlavor)' == 'mono'" >
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/Int128/Int128TestFieldLayout/*">
<Issue>https://github.com/dotnet/runtime/issues/74223</Issue>
</ExcludeList>
<ExcludeList Include = "$(XUnitTestBinBase)/JIT/Directed/Arrays/nintindexoutofrange/**">
<Issue>https://github.com/dotnet/runtime/issues/71656</Issue>
</ExcludeList>
Expand Down